test: replace common.fixturesDir with fixtures.#15802
Closed
codeviking wants to merge 1 commit intonodejs:masterfrom
Closed
test: replace common.fixturesDir with fixtures.#15802codeviking wants to merge 1 commit intonodejs:masterfrom
codeviking wants to merge 1 commit intonodejs:masterfrom
Conversation
richardlau
reviewed
Oct 6, 2017
Member
There was a problem hiding this comment.
This could alternatively be fixtures.path('x.txt').
Author
There was a problem hiding this comment.
Ah! Great. That seems better. I'll tweak that shortly.
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism.
codeviking
force-pushed
the
common-fixtures
branch
from
52fcf84 to
65aabc5
Compare
Author
|
@richardlau I updated to use |
richardlau
approved these changes
Oct 6, 2017
Trott
added
the
code-and-learn
gireeshpunathil
approved these changes
Oct 7, 2017
cjihrig
approved these changes
Oct 7, 2017
Member
Trott
approved these changes
Oct 8, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 8, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: nodejs#15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in eb08e3e. |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: #15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: nodejs/node#15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 14, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: #15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: #15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Replaces the use of `common.fixturesDir` with the generic `fixtures` mechanism. PR-URL: #15802 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the use of
common.fixturesDirwith the genericfixturesmechanism.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)