test: Mark test-stop-profile-after-done flaky#14874
Merged
eugeneo merged 0 commit intonodejs:masterfrom Aug 17, 2017
eugeneo:profiler-aix
Merged
test: Mark test-stop-profile-after-done flaky#14874eugeneo merged 0 commit intonodejs:masterfrom eugeneo:profiler-aix
eugeneo merged 0 commit intonodejs:masterfrom
eugeneo:profiler-aix
Conversation
nodejs-github-bot
added
dont-land-on-v4.x
inspector
refack
suggested changes
Aug 16, 2017
test/inspector/inspector.status
Outdated
Contributor
There was a problem hiding this comment.
so could you put it in Windows and AIX?
Contributor
There was a problem hiding this comment.
Just add
[$system==aix]
test-stop-profile-after-done: PASS, FLAKY
Contributor
Author
|
Updated the CL, thank you for looking into it. |
refack
approved these changes
Aug 17, 2017
Contributor
Thanks for following up. |
cjihrig
approved these changes
Aug 17, 2017
mhdawson
approved these changes
Aug 17, 2017
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, I also think we don't necessarily wait for the 48 hour period for this one. We are better off avoiding the failures/red in the CI and the change is not likely to be controversial.
Member
Contributor
Author
|
Test parallel/test-http2-multiplex on ARM is the only CI failure. I will land this PR now. |
Contributor
Author
|
Landed as 7027191 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 10, 2017
It is flaky on Windows and AIX. Some more time is needed to fix it. PR-URL: #14874 (review) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 12, 2017
It is flaky on Windows and AIX. Some more time is needed to fix it. PR-URL: #14874 (review) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is flaky on Windows and AIX. Some more time is needed to fix it.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)