doc: doc lifetime of n-api last error info#13939
Closed
mhdawson wants to merge 2 commits intonodejs:masterfrom
Closed
doc: doc lifetime of n-api last error info#13939mhdawson wants to merge 2 commits intonodejs:masterfrom
mhdawson wants to merge 2 commits intonodejs:masterfrom
Conversation
Document the lifetime of the structure returned by napi_get_last_error_info Fixes: nodejs/abi-stable-node#251
nodejs-github-bot
added
doc
doc/api/n-api.md
Outdated
| This API retrieves a `napi_extended_error_info` structure with information | ||
| about the last error that occurred. | ||
|
|
||
| *Note*: The content of the 'napi_extended_error_info` returned is only |
Contributor
There was a problem hiding this comment.
Wrong quote before napi_?
Member
Author
There was a problem hiding this comment.
Thanks ! Pushed commit to fix.
jasnell
approved these changes
Jun 26, 2017
digitalinfinity
approved these changes
Jun 27, 2017
Contributor
digitalinfinity
left a comment
digitalinfinity
left a comment
There was a problem hiding this comment.
I see the same issue as @vsemozhetbyt - other than that LGTM
cjihrig
approved these changes
Jun 27, 2017
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with the quote nit addressed.
vsemozhetbyt
approved these changes
Jun 27, 2017
Member
Author
Member
Author
|
CI good landing. |
Member
Author
|
Landed as ef28d85 |
mhdawson
added a commit
that referenced
this pull request
Jun 28, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 29, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 10, 2018
Document the lifetime of the structure returned by napi_get_last_error_info PR-URL: nodejs#13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 16, 2018
Document the lifetime of the structure returned by napi_get_last_error_info Backport-PR-URL: #19447 PR-URL: #13939 Fixes: nodejs/abi-stable-node#251 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the lifetime of the structure returned
by napi_get_last_error_info
Fixes: nodejs/abi-stable-node#251
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, n-api