Repository navigation
ContextifyContext::PropertyDefinerCallback() never intercepts the request #52634
Description
Version
v22.0.0-pre
Platform
No response
Subsystem
No response
What steps will reproduce the bug?
While migrating Node-ci to a new V8 interceptors Api (https://crrev.com/c/5353146, v8#180) I noticed that ContextifyContext::PropertyDefinerCallback() never reports that it has intercepted the request.
It should have called args.GetReturnValue()->SetUndefined(); in define_prop_on_sandbox instead.
Fixing this issue exposes another one - ContextifyContext::PropertyEnumeratorCallback() never returns symbol properties because ctx->sandbox()->GetPropertyNames(ctx->context()) skips symbols. There's a GetPropertyNames() overload with a PropertyFilter parameter which can be configured to not skip symbols.
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
n/a
Additional information
No response
Activity
github-actions commentedon May 22, 2026
This issue has been marked as stale due to 210 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
src: fix ContextifyContext property definer interception result
src: fix ContextifyContext property definer interception result
src: fix ContextifyContext property definer interception result
[execution] Lookup interceptor for RestrictedGlobalProperty
deps: V8: backport a05321ebd98e
deps: V8: backport a05321ebd98e
deps: V8: backport a05321ebd98e
deps: V8: backport a05321ebd98e
deps: V8: backport a05321ebd98e