Misplaced/dead Windows code in `node.cc`?

[targos]

In

node/src/node.cc

Lines 633 to 640 in 756acd0

	#if NODE_USE_V8_WASM_TRAP_HANDLER
	#if defined(_WIN32)
	{
	constexpr ULONG first = TRUE;
	per_process::old_vectored_exception_handler =
	AddVectoredExceptionHandler(first, TrapWebAssemblyOrContinue);
	}
	#else

, we have Windows-specific code.
The problem is that this code is inside a #ifdef __POSIX__ section:

node/src/node.cc

Line 553 in 756acd0

#ifdef __POSIX__

This seems to be unexpected dead code for Windows.
I found this from a compiler warning: src\node.cc(428,13): warning : unused function 'TrapWebAssemblyOrContinue' [-Wunused-function] [D:\Git\nodejs\node\libnode.vcxproj]

[targos]

The code was added in 0577127 and I think it's always been inside the __POSIX__ section.

[targos]

@nodejs/cpp-reviewers

[tniessen]

cc @devsnek

[devsnek]

nice catch. given i've never had a windows development machine i would assume i was relying on our windows ci when i wrote the linked commit. i guess since the trap handler was never installed and V8:EnableWebAssemblyTrapHandler(false); is also inside the POSIX, the entire commit was effectively no-op. if anyone cares about wasm performance on windows it could be nice to fix.

[thisalihassan]

I will make a PR for this