Fix bugs in named interceptor test.#782
Merged
kkoopa merged 1 commit intonodejs:masterfrom May 26, 2018
bnoordhuis:fix-named-interceptor-test
Merged
Fix bugs in named interceptor test.#782kkoopa merged 1 commit intonodejs:masterfrom bnoordhuis:fix-named-interceptor-test
kkoopa merged 1 commit intonodejs:masterfrom
bnoordhuis:fix-named-interceptor-test
Conversation
The PropertyQuery callback needs to return _something_ in order for V8 to consider the property present in Node.js 10. Fixes failing test test/js/namedinterceptors-test.js
Collaborator
|
Thank you. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PropertyQuery callback needs to return something in order for V8
to consider the property present in Node.js 10.
Fixes failing test test/js/namedinterceptors-test.js