lookup: skip moment

[BethGriggs]

Moment is currently failing on all platforms - moment/moment#5334

Checklist

• npm test passes
• contribution guidelines followed
  here

[BethGriggs]

citgm-nobuild run on v12.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker-nobuild/lastCompletedBuild/testReport/

[BethGriggs]

If I mark something skip=true in CITGM, do I need to wait for a new release of citgm for that to be taken into account in the citgm CI runs?

[codecov-io]

Codecov Report

Merging #777 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          27       27           
  Lines         888      888           
=======================================
  Hits          848      848           
  Misses         40       40

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d0b2f...8c28803. Read the comment docs.

[richardlau]

If I mark something skip=true in CITGM, do I need to wait for a new release of citgm for that to be taken into account in the citgm CI runs?

Yes. I can’t do that right now until Sunday at the earliest but maybe someone else could.

[sam-github]

@BethGriggs maybe use the CITGM job parameter?

what citgm should npm install: "npm install -g $CITGM" (can be replaced with any npm compatible path)

npm install -g nodejs/citgm should install citgm from master, from github.com, so you might be able to use that to run a citgm with your latest lookup.json without waiting for an npm publish.

[MylesBorins]

Sam's suggestion is a good one. A couple of thoughts

• There is not need for review lookup changes in our current governance
• numbers are cheap... it is quite easy to quickly publish after landing a change to the lookup (this is how I've done it)
• I opened an issue for other to get added to publish rights

[MylesBorins]

LGTM

[MylesBorins]

also fwiw I've landed this and published a new version of citgm

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.49%. Comparing base (37d0b2f) to head (8c28803).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #777   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          27       27           
  Lines         888      888           
=======================================
  Hits          848      848           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.