Skip to content

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Apr 1, 2022

Proposed changes

This PR implements a cert-manager controller to automate the provision and management of Certificate resources for VirtualServer resources using cert-manager. This mimics the functionality available for Ingress and Gateway resources (see https://cert-manager.io/docs/usage/gateway/).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Apr 1, 2022
@ciarams87 ciarams87 requested a review from haywoodsh April 1, 2022 16:07
@ciarams87 ciarams87 added enhancement Pull requests for new features/feature enhancements and removed dependencies Pull requests that update a dependency file labels Apr 3, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Apr 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #2572 (0e30eeb) into main (ae4cb94) will increase coverage by 0.06%.
The diff coverage is 56.54%.

❗ Current head 0e30eeb differs from pull request most recent head 9fa11ed. Consider uploading reports for the commit 9fa11ed to get more accurate results

@@            Coverage Diff             @@
##             main    #2572      +/-   ##
==========================================
+ Coverage   53.50%   53.56%   +0.06%     
==========================================
  Files          49       52       +3     
  Lines       14299    14675     +376     
==========================================
+ Hits         7651     7861     +210     
- Misses       6407     6554     +147     
- Partials      241      260      +19     
Impacted Files Coverage Δ
cmd/nginx-ingress/main.go 6.91% <0.00%> (-0.07%) ⬇️
internal/configs/config_params.go 76.74% <ø> (ø)
internal/k8s/controller.go 10.87% <0.00%> (-0.04%) ⬇️
internal/certmanager/cm_controller.go 18.80% <18.80%> (ø)
internal/certmanager/sync.go 71.65% <71.65%> (ø)
pkg/apis/configuration/validation/virtualserver.go 96.21% <82.60%> (-0.04%) ⬇️
internal/certmanager/helper.go 100.00% <100.00%> (ø)
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ciarams87 ciarams87 force-pushed the certmanager branch 2 times, most recently from ff3cbac to 9a4f092 Compare April 5, 2022 12:37
@ciarams87 ciarams87 force-pushed the certmanager branch 3 times, most recently from c12e71f to 42200c0 Compare April 6, 2022 13:23
@ciarams87 ciarams87 force-pushed the certmanager branch 2 times, most recently from ca497ad to 439d0b9 Compare April 6, 2022 13:47
@ciarams87 ciarams87 force-pushed the certmanager branch 2 times, most recently from 0e30eeb to 1b75acc Compare April 7, 2022 16:41
@ciarams87 ciarams87 merged commit 192c76f into main Apr 7, 2022
@ciarams87 ciarams87 deleted the certmanager branch April 7, 2022 21:57
@ciarams87 ciarams87 removed the dependencies Pull requests that update a dependency file label Apr 8, 2022
@ciarams87 ciarams87 changed the title Implement cert-manager for support for VirtualServer resources Automate provisioning of Certificate resources for VirtualServer resources using cert-manager Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants