Skip to content

feat: Update Contributing guidelines for writers #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 23, 2025

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Apr 17, 2025

Proposed changes

This commit updates the CONTRIBUTING_DOCS.md file to our contemporary standards for documentation formatting, adding mention of Hugo archetypes and our ghcode shortcode, while also removing some slightly redundant information.

Certain sentences have been removed or simplified to reduce the amount of contextual reading required: in certain cases, the reader is guided to refer to the style guide for more precise information, such as in the case of using images.

There will likely be follow-up work in the future to more cleanly delineate guidance for using Hugo and guidance around writing content in a general sense, to tightly scope the purpose of this document in relation to the style guide.

Closes issue #164

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content.

This commit updates the CONTRIBUTING_DOCS.md file to our contemporary
standards for documentation formatting, adding mention of Hugo
archetypes and our ghcode shortcode, while also removing some slightly
redundant information.

Certain sentences have been removed or simplified to reduce the amount
of contextual reading required: in certain cases, the reader is guided
to refer to the style guide for more precise information, such as in the
case of using images.

There will likely be follow-up work in the future to more cleanly
delineate guidance for using Hugo and guidance around writing content in
a general sense, to tightly scope the purpose of this document in
relation to the style guide.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner April 17, 2025 15:30
@github-actions github-actions bot added the process documentation Documentation related to how the repository or documention itself is managed. label Apr 17, 2025
Copy link

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/428/

Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I won't stop this change, it feels like we're now writing CONTRIBUTING_DOCS.md for the developer.

Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
Co-authored-by: Travis Martin <33876974+travisamartin@users.noreply.github.com>
@javorszky
Copy link

Hi, engineer on the NIC team here. I would very much love it if I, and other engineers, were also regarded as a target audience for this document. Part of our workflow is creating the features and the documentation for said features. In my view the less work the docs team needs to do on any doc changes, the better, but that can only happen if we, the engineers, know what to do in the first place 🙂

I also like overexplaining things. I'd rather that than having to open several new tabs to figure out what's what.

Though it doesn't matter, I do call them backticks.

@mjang
Copy link
Contributor

mjang commented Apr 22, 2025

Hi, engineer on the NIC team here. I would very much love it if I, and other engineers, were also regarded as a target audience for this document. Part of our workflow is creating the features and the documentation for said features. In my view the less work the docs team needs to do on any doc changes, the better, but that can only happen if we, the engineers, know what to do in the first place 🙂

I also like overexplaining things. I'd rather that than having to open several new tabs to figure out what's what.

Though it doesn't matter, I do call them backticks.

Hi @javorszky , I appreciate your perspective, and your efforts to create documentation for NIC. It's helpful, and I appreciate your work.

One of the reasons we created this open source repository is to appeal to less technical users. Today, we have contributions from both technical and less technical users. Most of the technical users are from within NGINX and F5. Since we have two audiences, I did suggest that we have F5-NGINX-* files for those of us from NGINX and F5.

@ADubhlaoich ADubhlaoich merged commit be62861 into main Apr 23, 2025
9 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/update-new-instructions branch April 23, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process documentation Documentation related to how the repository or documention itself is managed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants