Workaround for unintentional reset on UpdateConfiguration

[muenchris]

Description

• Added check for different DHCP mode and call UpdateConfiguration only if needed.

Motivation and Context

• Fixes NetworkHelper.SetupAndConnectNetwork fails on ESP32_OLIMEX_WROVER with Firmware >1.14 Home#1690

How Has This Been Tested?

Screenshots

Types of changes

• Bug fix (non-breaking change which fixes an issue with code or algorithm)

Checklist:

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
• I have added new tests to cover my changes.

[coderabbitai]

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)

• nanoFramework.System.Net/NetworkInformation/NetworkInterface.cs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nfbot]

@muenchris I've fixed the checklist for you.
FYI, the correct format is [x], no spaces inside brackets, no other chars.

[Ellerbach]

Thanks a lot for the fix

[Ellerbach]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[josesimoes]

Looking at this makes me think that the root cause should be in the native code when it's executing the UpdateConfig. Some wrong pointer or check or... I guess this will surface again when there is a call to it because of other config change that calls it...
Nevertheless, I'm merging it.

[nfbot]

@muenchris thank you again for your contribution! 🙏😄

.NET nanoFramework is all about community involvement, and no contribution is too small.
We would like to invite you to join the project's Contributors list.

Please edit it and add an entry with your GitHub username in the appropriate location (names are sorted alphabetically):

  <tr>
    <td><img src="https://github.com/muenchris.png?size=50" height="50" width="50" ></td>
    <td><a href="https://github.com/muenchris">Chris Muench</a></td>
  </tr>

(Feel free to adjust your name if it's not correct)

[muenchris]

Looking at this makes me think that the root cause should be in the native code when it's executing the UpdateConfig. Some wrong pointer or check or... I guess this will surface again when there is a call to it because of other config change that calls it... Nevertheless, I'm merging it.

Yes, I think so, too, because the System.Net code has not changed since fw 1.12.xx. There might be more "broken" in the native code as reported in issue #1692