Repository navigation
emit "additionalProperties": false with rfl::NoExtraFields - #728
Merged
liuzicheng1987 merged 2 commits intoOct 26, 2026
Merged
liuzicheng1987 merged 2 commits into
liuzicheng1987 merged 2 commits into
Conversation
gg-sr
force-pushed
the
schema-additional-properties
branch
from
September 23, 2026 08:08
30be66a to
2bcf820
Compare
Collaborator
|
@gg-sr I think this makes a lot of sense, but the tests need to be adapted to make this work. Could you take care of that? |
gg-sr
force-pushed
the
schema-additional-properties
branch
from
September 27, 2026 23:13
88658db to
bc99d8c
Compare
Contributor
Author
|
@liuzicheng1987 Right, fixed in bc99d8c, sorry! One of the CI checks failed, but it seems like a transient error. Some checks took a while to finish, but I don't think it's related to this change. |
Contributor
|
@liuzicheng1987 The only CI failure here is vcpkg hiccup, I think it should be merged if that was the only blocker |
Collaborator
liuzicheng1987
merged commit Oct 26, 2026
587b72e
into
munich-data-engineering:main
175 of 176 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.