Repository navigation
Conversation
This was referenced Oct 13, 2026
Core appends them as the run's producer then. A failed task's rerun publishes again under the next attempt.
Owner
Author
|
Closed. The Ford project (Core Workflow Task publish) is dropped. Brook now publishes from a Workflow through a local activity, with no Core change. Bridge moves onto Brook in the coming Jetty re-cut. This branch stays until then, because Bridge PRs still sit on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
workflow_writer(), whose records ride the completion of the activation that published them.WorkflowStreamWriterhaspublish(value)andfinish().FINISHis idempotent per topic, and a publish after it is refused.WorkflowOutputStreamCommitcommand. A failed activation drops it with the completion.@<run id>, and writes the marker. If the task fails, the records stay, and its rerun publishes again under the run's next attempt, which readers see asSUPERSEDED.StreamErrorat the call. A query or an Update validator can't publish.workflow_activity_writerstays, so a Workflow can still publish through an Activity.Why?
A Workflow that runs model and tool calls as Local Activities in one long Workflow Task must show each record when it is published, not when the task ends. Core owns the append and the marker, so lang hands over records and keeps no manifest or History read (DD-87).
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_workflow_writer.pyruns on the dev server and reads through Core's stream service.