Skip to content

[Ford] Handed a Worker's stream store to Core. - #163

Closed
moetemp wants to merge 6 commits into
moe/brook/v2/h2-local-activity-producerfrom
moe/ford/w1-worker-stream-store
Closed

moetemp wants to merge 6 commits into
moe/brook/v2/h2-local-activity-producerfrom
moe/ford/w1-worker-stream-store

Conversation

@moetemp

@moetemp moetemp commented Oct 13, 2026 •

Copy link
Copy Markdown
Owner

What changed?

This PR hands a Worker's stream store to Core, so Core can append a Workflow's output to it.

  • The bridge WorkerConfig gains stream_store, and convert_worker_config passes it to Core.
  • StreamStorePlugin offers its store under _temporal_stream_store, and the Worker reads it from its plugins. That keeps the bridge type off the public Worker options.
  • Separate commits pin Core to the Ford top 43e95428, which adds the output commit, the append at activation completion, the topic and chain closes and the Worker store. Core's changelog fragment comes with them, and the generated protos and payload visitor follow the pin.

Why?

The Workflow Task publish needs Core's Worker to hold the store (DD-87). Brook doesn't publish from a Workflow Task, so this starts Ford.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

tests/contrib/streams/test_store_plugin.py checks the store reaches the Worker.

Core appends a Workflow's records when the activation completes, and the
output manifest has no stage token.
@moetemp
moetemp changed the base branch from moe/brook/v2/h1-workflow-activity-writer to moe/brook/v2/h2-local-activity-producer October 13, 2026 23:02
@moetemp moetemp added the parked Parked design, not for review label Oct 14, 2026
@moetemp

moetemp commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

Closed. The Ford project (Core Workflow Task publish) is dropped. Brook now publishes from a Workflow through a local activity, with no Core change. Bridge moves onto Brook in the coming Jetty re-cut. This branch stays until then, because Bridge PRs still sit on it.

@moetemp moetemp closed this Oct 14, 2026
@moetemp
moetemp deleted the moe/ford/w1-worker-stream-store branch October 14, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parked Parked design, not for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant