Repository navigation
Conversation
Ford's Core rewrote two existing entries, and update-core imports only new ones.
This was referenced Oct 13, 2026
Core appends a Workflow's records when the activation completes, and the output manifest has no stage token.
moetemp
changed the base branch from
moe/brook/v2/h1-workflow-activity-writer
to
moe/brook/v2/h2-local-activity-producer
October 13, 2026 23:02
Owner
Author
|
Closed. The Ford project (Core Workflow Task publish) is dropped. Brook now publishes from a Workflow through a local activity, with no Core change. Bridge moves onto Brook in the coming Jetty re-cut. This branch stays until then, because Bridge PRs still sit on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR hands a Worker's stream store to Core, so Core can append a Workflow's output to it.
WorkerConfiggainsstream_store, andconvert_worker_configpasses it to Core.StreamStorePluginoffers its store under_temporal_stream_store, and the Worker reads it from its plugins. That keeps the bridge type off the public Worker options.43e95428, which adds the output commit, the append at activation completion, the topic and chain closes and the Worker store. Core's changelog fragment comes with them, and the generated protos and payload visitor follow the pin.Why?
The Workflow Task publish needs Core's Worker to hold the store (DD-87). Brook doesn't publish from a Workflow Task, so this starts Ford.
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_store_plugin.pychecks the store reaches the Worker.