Repository navigation
Conversation
The suite is what a provider passes to prove the publish contract, and the memory provider is its in-process reference.
A Workflow publishes to its own stream through the provider, and a publish from a query or an update validator is refused at the call.
Concurrent appends read the same sequence before either wrote, so records carried wrong sequences. The provider is also marked as test-only.
# Conflicts: # temporalio/contrib/streams/__init__.py
A resumed read missed SUPERSEDED, a record that failed to decode was skipped or stopped every read, and a batch starting inside the newest one was accepted. The conformance suite pins the first two for every provider.
The next run after Continue-as-New can publish on the topic again, under the same empty producer id.
# Conflicts: # temporalio/contrib/streams/_policy.py
The writer adds each record to one output commit command on the activation's completion, so the completion encoder runs the codec on its body and Core stages and promotes it. A failed activation drops the command with the rest of its completion.
Core stages an activation's bodies in one store call, so a huge body or activation failed the task on every retry, far from the publish that caused it.
moetemp
marked this pull request as draft
October 12, 2026 06:58
Owner
Author
|
Replaced by Ford #164. Brook was split in two: Brook now has streams with Activity and client publish and outside readers, and Ford has the Workflow Task publish path. The code is the same, re-cut into new branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds
workflow_writer(), whose records ride the completion of the activation that published them.WorkflowStreamWriterhaspublish(value)andfinish().FINISHis idempotent per topic, and a publish after it is refused.WorkflowOutputStreamCommitcommand. A failed activation drops it with the completion.StreamErrorat the call. A query or an Update validator can't publish.Why?
A Workflow's publish becomes visible only when its task is accepted (DD-4). Core owns that commit, so lang hands over records and keeps no manifest, stage or History read (DD-87).
How did you test it?
Link to a test plan if any -
tests/contrib/streams/test_workflow_writer.pyruns on the dev server and reads through Core's stream service.