Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lightningdevkit/ldk-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: modular-ops/mobile-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 19 files changed
  • 2 contributors

Commits on Apr 25, 2024

  1. Move BOLT11 payments API to Bolt11PaymentHandler

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6ed3796 View commit details
    Browse the repository at this point in the history

  2. Move spontaneous payments API to SpontaneousPaymentHandler

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    06a432d View commit details
    Browse the repository at this point in the history

  3. Move onchain payments API to OnchainPaymentHandler

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    61098fa View commit details
    Browse the repository at this point in the history

  4. Move payment_store to payment submodule 

    .. which declutters our top-level docs a bit.
    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    112e94b View commit details
    Browse the repository at this point in the history

  5. Introduce PaymentKind to payment store, track by PaymentId

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    4e89348 View commit details
    Browse the repository at this point in the history

  6. Add test ensuring de/ser compatibility with old format 

    .. as we changed quite a bit and moved required fields, we add a test
here that adds the old `PaymentDetails` as a test struct and ensures
we're able to parse them just fine
    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    8710628 View commit details
    Browse the repository at this point in the history

  7. Add payment_id to Payment{Successful,Failed,Received} events

    @tnull
    tnull committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    28476cb View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Merge pull request #1 from tnull/2024-03-payment-api-refactor 

    2024 03 payment api refactor
    @jbesraa
    jbesraa authored Apr 27, 2024
    Configuration menu
    Copy the full SHA
    61a0eb2 View commit details
    Browse the repository at this point in the history
Loading