Fix race in KestrelInMemoryConnection #233
Merged
halter73 merged 2 commits intomodelcontextprotocol:mainfrom Apr 7, 2025
Merged
Fix race in KestrelInMemoryConnection #233halter73 merged 2 commits intomodelcontextprotocol:mainfrom
halter73 merged 2 commits intomodelcontextprotocol:mainfrom
Conversation
stephentoub
approved these changes
Apr 7, 2025
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should avoid the following race. I went the easy route, and just stop disposing KestrelInMemoryConnection._connectionClosedCts, because IIRC, you only really need to dispose it if a caller is using something like CancellationToken.WaitHandle, which I don't expect in our tests at least. I could try synchronizing with the SocketsHttpHandler disposing the stream on a background thread, but it was a lot more code and risked deadlocks if done incorrectly.
https://github.com/modelcontextprotocol/csharp-sdk/actions/runs/14319353286/job/40132789327