Fix: assign_mocks should update records regardless of current state#161
Open
prjanitor wants to merge 1 commit intomocktools:masterfrom
Open
Fix: assign_mocks should update records regardless of current state#161prjanitor wants to merge 1 commit intomocktools:masterfrom
prjanitor wants to merge 1 commit intomocktools:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
assign_mocksmethod inlib/dns_mock/server.rbonly updates the records hash when it is currently empty:This prevents users from updating existing mock configurations after the server has been initialized with records.
Solution
Remove the conditional check so that
assign_mocksalways updates the records:Impact
assign_mocks- it should assign/update the mocksThis PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.