-
Notifications
You must be signed in to change notification settings - Fork 18.9k
libnetwork: support custom DNS servers in Windows overlay driver #51229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| // Todo: Add port bindings and qos policies here | ||
|
|
||
| epOption, err := windows.ParseEndpointOptions(epOptions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the moment, it looks we just ignore options like com.docker.network.endpoint.macaddress in this case ... after this change we'll return an error if those options are malformed, then still ignore them. Which might be even more confusing/annoying?
Maybe it'd be marginally better to continue ignoring those other options, by splitting a ParseDNSServers out of parseEndpointOptions and calling that from here?
Signed-off-by: Olli Janatuinen <olli.janatuinen@gmail.com>
9c39aa0 to
48c2d8c
Compare
robmry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thank you.
|
@robmry do we need a change-log entry for this one? (Also not sure if there's docs mentioning "doesn't work on Windows") |
I don't see any docs to be updated, I've added a release note. |
thaJeztah
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- What I did
Decision in #19474 seems to be that there is no option to disable embedded DNS but user can provide own DNS servers with
--dnsoption. However that logic does not exist in Windows version of overlay driver so I fixed that.- How I did it
Copy & paste logic from non-overlay driver:
moby/daemon/libnetwork/drivers/windows/windows.go
Line 732 in 663aa7a
- How to verify it
Create attachable test network:
docker network create --driver overlay --attachable testStart test container:
NOTE! In Windows, gateway is always first DNS server inside of the container but internally DNS server(s) provided by user are used. That can be confirmed by testing with both valid and invalid DNS server IP addresses.
- Human readable description for the release notes