Skip to content

fix: editor tabs keyboard navigation #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinbarron merged 5 commits into from
Jun 2, 2023
Merged

fix: editor tabs keyboard navigation #2371

gavinbarron merged 5 commits into from
Jun 2, 2023

Conversation

@gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented Jun 1, 2023

Closes #2248

PR Type

  • Bugfix

Description of the changes

makes visual tabs in editor behave like aria tabs

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@gavinbarron
fix: editor tabs keyboard navigation
6ab2650 
makes visual tabs in editor behave like aria tabs
@gavinbarron gavinbarron requested a review from a team as a code owner June 1, 2023 13:56
@ghost
Copy link

ghost commented Jun 1, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

sebastienlevert
sebastienlevert approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@sebastienlevert sebastienlevert linked an issue Jun 1, 2023 that may be closed by this pull request
{Freeway-Bug}[MGTP-Properties-Get by day-html]: Screen reader doesn't announce role and selected state for 'html', 'js', 'css' tab items. #2248
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

@gavinbarron
Copy link
Member Author

gavinbarron commented Jun 1, 2023

@vagpt and @KarunaNarang this item is ready for review

musale
musale approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@musale musale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfect! This exposes the tabs to more customizations incase it's needed.

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

The updated storybook is available here

@gavinbarron gavinbarron enabled auto-merge (squash) June 2, 2023 18:39
@gavinbarron gavinbarron merged commit 669b1ea into next/fluentui Jun 2, 2023
@gavinbarron gavinbarron deleted the bug/editor-tabs branch June 2, 2023 18:48
@github-actions
Copy link

github-actions bot commented Jun 2, 2023

The updated storybook is available here

This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebastienlevert sebastienlevert sebastienlevert approved these changes

+1 more reviewer

@musale musale musale approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

{Freeway-Bug}[MGTP-Properties-Get by day-html]: Screen reader doesn't announce role and selected state for 'html', 'js', 'css' tab items.

4 participants

@gavinbarron @sebastienlevert @musale