fix: remove theme-toggle capability from custom CSS property and templating stories #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
|
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
Contributor
Author
|
@sebastienlevert you had mentioned something about this in one of the issues but I can't find it. Please, could you point me to it? |
|
The updated storybook is available here |
1 similar comment
|
The updated storybook is available here |
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
|
The updated storybook is available here |
gavinbarron
requested changes
May 17, 2023
ghost
added
the
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
Signed-off-by: Martin Musale <martinmusale@microsoft.com>
|
The updated storybook is available here |
gavinbarron
approved these changes
May 18, 2023
Collaborator
|
Hi @musale, This issue is still repro on the environment below, please refer to the attached snippet for reference. Snippet:
|
This was referenced Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2240
PR Type
Description of the changes
Removes the theme toggle from the custom CSS properties story and templating pages. These pages are customized hence we default to a light mode in the playground.
PR checklist
yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense)Other information