Skip to content

fix: add title tag in location icon svg #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
musale merged 6 commits into from
May 30, 2023
Merged

fix: add title tag in location icon svg #2285

musale merged 6 commits into from
May 30, 2023

Conversation

@musale
Copy link
Contributor

@musale musale commented May 11, 2023

Closes #2235

PR Type

  • Bugfix

Description of the changes

Added a title tag in the location icon svg so that it announces in narrator.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale
Add a title tag to be announced for svgs
1823369 
Signed-off-by: Musale Martin <martinmusale@microsoft.com>
@ghost
Copy link

ghost commented May 11, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

gavinbarron
gavinbarron approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@gavinbarron gavinbarron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@musale musale linked an issue May 16, 2023 that may be closed by this pull request
[MGTP-Left Navigation-Custom Properties]: Proper alt is not defined for the ‘Location’ icon under ‘Custom Properties’ page. #2235
Closed
@github-actions
Copy link

github-actions bot commented May 16, 2023

The updated storybook is available here

@gavinbarron
Copy link
Member

gavinbarron commented May 16, 2023

@vagpt and @KarunaNarang this is ready to be tested

@github-actions
Copy link

github-actions bot commented May 16, 2023

The updated storybook is available here

@Mnickii Mnickii requested a review from a team as a code owner May 26, 2023 12:15
@github-actions
Copy link

github-actions bot commented May 26, 2023

The updated storybook is available here

@github-actions
Copy link

github-actions bot commented May 29, 2023

The updated storybook is available here

@musale musale merged commit 8c601c9 into next/fluentui May 30, 2023
@musale musale deleted the ac11y-2235 branch May 30, 2023 11:27
This was referenced Jul 17, 2023
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinbarron gavinbarron gavinbarron approved these changes

@sebastienlevert sebastienlevert sebastienlevert approved these changes

@Mnickii Mnickii Awaiting requested review from Mnickii

@vagpt vagpt Awaiting requested review from vagpt

Assignees

No one assigned

Labels

Build: Storybook

Projects

Graph Toolkit
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MGTP-Left Navigation-Custom Properties]: Proper alt is not defined for the ‘Location’ icon under ‘Custom Properties’ page.

5 participants

@musale @gavinbarron @sebastienlevert @Mnickii