Skip to content

Conversation

@musale
Copy link
Contributor

@musale musale commented May 4, 2023

Closes #2157
Closes #2138

PR Type

  • Deprecation

Description of the changes

Removes the TeamsProvider and TeamsMsal2Provider in favour of the TeamsFxProvider.
Removes the MsalProvider in favor of the Msal2Provider.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale added this to the v3.0.0 milestone May 4, 2023
@ghost
Copy link

ghost commented May 4, 2023

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@musale musale changed the title feat: deprecate the TeamsProvider, TeamsMsal2Provider and the MsalProvider feat: remove the TeamsProvider, TeamsMsal2Provider and the MsalProvider May 4, 2023
@ghost ghost added the Needs: Author Feedback Issue needs response from issue author label May 4, 2023
@musale musale changed the title feat: remove the TeamsProvider, TeamsMsal2Provider and the MsalProvider feat: remove the Teams, TeamsMsal2 and the Msal providers in v3.x.x May 4, 2023
@ghost ghost removed the Needs: Author Feedback Issue needs response from issue author label May 4, 2023
@musale musale requested a review from gavinbarron May 8, 2023 08:22
Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we reference the npmjs package or a branch for the v2 features?

@gavinbarron
Copy link
Member

Should we reference the npmjs package or a branch for the v2 features?

Use npm for now, we should have a post go-live step to update these links to point at the branch IMO

@gavinbarron gavinbarron merged commit c007abc into next/fluentui May 16, 2023
@gavinbarron gavinbarron deleted the deprecate-msal-teams-providers branch May 16, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Deprecate TeamsMsal2Provider and TeamsMsalProvider in favor of TeamsFxProvider Deprecate mgt-msal-provider and mgt-teams-provider

5 participants