Exposed Open/Save dialog title on public VSCode Proposed API #90493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Change looks good to me. |
Contributor
Author
|
@alexr00 do you agree with these changes? |
Member
|
Yes, I just haven't had a chance to merge this yet :) |
alexr00
approved these changes
Feb 19, 2020
Member
|
Thank you for the PR! |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #82871.
Now open/save dialog title is exposed on public VSCode Proposed API.
I've tested on Ubuntu 19.10 with an extension which invokes showSaveDialog() and showOpenDialog() methods. Here's an usage example:
The example below shows My open title on the top of Open Dialog.
Note: on this version of Ubuntu the Save Dialog title is not shown, but it's an OS-related behaviour.
Every save dialog of VSCode running on Ubuntu 19.10 ignores the specified title as can be seen on 'File -> Save Workspace As...' (On Windows it shows 'Save Workspace' but on Ubuntu no title is shown).