Force commit messages output to UTF-8

[yutotnh (yutotnh)]

Fixes #331086

Summary

I modified the code to enforce the i18n.logOutputEncoding=UTF-8 setting when calling Git.

Test

The test I added checks whether commit messages written in an encoding other than UTF-8 (EUC-JP) are retrieved as UTF-8.
Without my fix, they would be retrieved as EUC-JP, causing the test to fail.

Image

Additional Information

Even after applying this setting, my local test results showed that the execution time remained unchanged.

I conducted the following experiment in the vscode repository.

If no settings are specified

$ time for i in $(seq 1 10) ;do git --no-pager log >& /tmp/output.txt ; done

real    0m12.062s
user    0m11.392s
sys     0m0.647s

If a setting is specified

$ time for i in $(seq 1 10) ;do git --no-pager -c i18n.logOutputEncoding=UTF-8 log >& /tmp/output.txt ; done

real    0m11.824s
user    0m11.034s
sys     0m0.768s

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

Ladislau Szomoru (@lszomoru)

Matched files:

• extensions/git/src/git.ts
• extensions/git/src/test/smoke.test.ts

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR improves handling of non-UTF-8 commit message encodings by forcing Git log output to UTF-8 and adds a smoke test to validate that behavior.

Changes:

• Added a smoke test that commits an EUC-JP encoded message and asserts it’s read back as UTF-8.
• Updated Git process spawning to apply i18n.logOutputEncoding=UTF-8 via -c for spawned Git commands.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
extensions/git/src/test/smoke.test.ts	Adds coverage for reading non-UTF-8 commit messages via repository log.
extensions/git/src/git.ts	Forces Git log output encoding to UTF-8 by injecting -c i18n.logOutputEncoding=UTF-8.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Dmitriy Vasyura (dmitrivMS)]

yutotnh (@yutotnh) Could you please address Copilot's comments?

[yutotnh (yutotnh)]

Dmitriy Vasyura (@dmitrivMS) Thanks for the comment.
I’ll work on this over the next few days.

[Copilot]

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Balanced

[Copilot]

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 0 new
• Review effort level: Balanced