Fire onDidChangeHeight after code block editor render completes. Fix #265031 #274691
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the code block rendering logic to fire a height change event after the asynchronous render() operation completes, ensuring the UI properly updates when rendering finishes.
Key Changes
- Modified
renderCodeBlockmethod to chain a.then()callback on theeditorInfo.render()promise to fire_onDidChangeHeightevent after rendering completes
src/vs/workbench/contrib/chat/browser/chatContentParts/chatMarkdownContentPart.ts
Show resolved
Hide resolved
Member
mjbvz
approved these changes
Nov 4, 2025
bpasero
approved these changes
Nov 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fire onDidChangeHeight after code block editor render completes. Fix #265031