-
Notifications
You must be signed in to change notification settings - Fork 37.1k
refactor(terminal): introduce ITerminalLaunchResult interface #256284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Tyriar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bytemain I'm curious what you needed to add?
need to know whether the
But I think the code I mentioned above will not contribute to the VSCode repository. |
|
Interesting. Note that the feature there is very much experimental and is likely to be tweaked. You probably don't want to depend upon it until the API is finalized tbh. |

The commit introduces a new interface
ITerminalLaunchResultto replace the previously used inline return type{ injectedArgs: string[] }in various terminal process-related methods.When I want to add an attribute to the return type of
start, I found that I have changed many files, so I want to add this pr first.