Skip to content

fix: remove necessary async declaration #247213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roblourens merged 1 commit into from
Apr 23, 2025
Merged

fix: remove necessary async declaration #247213

roblourens merged 1 commit into from
Apr 23, 2025

Conversation

@mortalYoung
Copy link
Contributor

@mortalYoung mortalYoung commented Apr 23, 2025

prepareChatAgentRequest don't need to be defined as an async function as it doesn't have asynchronous behavior.

roblourens
roblourens approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens enabled auto-merge (squash) April 23, 2025 16:41
@roblourens roblourens added this to the April 2025 milestone Apr 23, 2025
@roblourens roblourens merged commit d835965 into microsoft:main Apr 23, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@roblourens roblourens roblourens approved these changes

@rzhao271 rzhao271 rzhao271 approved these changes

Assignees

@roblourens roblourens

Labels

None yet

Projects

None yet

Milestone

April 2025

Development

Successfully merging this pull request may close these issues.

3 participants

@mortalYoung @roblourens @rzhao271