fix: add electron as an external for webpack #239134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
due to the nature of this change, we will hold off on it til Monday so we can let it bake in Insiders. |
Member
|
You can trigger a bundled build by running: Which will build the macOS ARM build. You can see all of our targets with: |
TylerLeonhardt
approved these changes
Feb 3, 2025
Member
TylerLeonhardt
left a comment
TylerLeonhardt
left a comment
There was a problem hiding this comment.
I verified that the bundled code for GitHub & Microsoft auth extensions now require "electron"
Contributor
Author
Thank you for verifying! 🎉 |
Tyriar
approved these changes
Feb 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue where
require('electron')does not resolve on the bundled extension after #238149Note, I don't see how to bundle the extension locally to confirm that this is working.
cc #207867