Skip to content

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jan 10, 2025

This implements an idea proposed in #237619.

image

@gjsjohnmurray
Copy link
Contributor Author

/assign @benibenj

I am enumerating all 3 settings in the call to Settings Editor because a simpler filter on explorer.openEditors returns some unrelated matches.

@gjsjohnmurray
Copy link
Contributor Author

Just discovered that @feature:explorer openEditors would achieve the matches I want, and might be more future-proof. What do you think?

@gjsjohnmurray
Copy link
Contributor Author

For future consideration we could add a similar option to the Outline view's overflow menu, using @feature:explorer outline as the settings search value.

Similarly for Timeline view, where timeline. seems to isolate the relevant settings.

@benibenj
Copy link
Contributor

Nice find with @feature:explorer openEditors, let's use that. Enumerating the setting IDs will be annoying to maintain

@gjsjohnmurray
Copy link
Contributor Author

Done.

Copy link
Contributor

@benibenj benibenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benibenj benibenj enabled auto-merge (squash) January 11, 2025 11:38
@vs-code-engineering vs-code-engineering bot added this to the January 2025 milestone Jan 11, 2025
@benibenj benibenj closed this Jan 12, 2025
auto-merge was automatically disabled January 12, 2025 10:39

Pull request was closed

@benibenj benibenj reopened this Jan 12, 2025
@benibenj benibenj enabled auto-merge (squash) January 12, 2025 10:39
@gjsjohnmurray
Copy link
Contributor Author

@benibenj the CI needs some kind of nudge on this PR to get it to merge.

@mcsmith1994
Copy link

Hi acknowledge me

@benibenj benibenj merged commit 567f6e3 into microsoft:main Jan 13, 2025
7 checks passed
@gjsjohnmurray gjsjohnmurray deleted the do-237619 branch January 13, 2025 11:10
benibenj added a commit that referenced this pull request Feb 18, 2025
benibenj added a commit that referenced this pull request Feb 24, 2025
Revert "Add a Configure option to overflow menu of Open Editors view (#237678)"

This reverts commit 567f6e3.
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants