Skip to content

Conversation

@tmm1
Copy link
Contributor

@tmm1 tmm1 commented Jan 8, 2025

  • tsb: normalize filenames consistently in add/removeScriptSnapshot
  • tsb: avoid processing css imports

cc @jrieken

Copy link

@AkiraYuki-04 AkiraYuki-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add Return Consistency
Currently, the method returns the result of delete this._snapshots[filename], but if other deletions fail, this isn’t reflected. Instead, track and return the overall success:

@mjbvz mjbvz assigned jrieken and unassigned mjbvz Jan 8, 2025
@tmm1
Copy link
Contributor Author

tmm1 commented Jan 8, 2025

The return value is unused so I don't think it matters. The current implementation seems correct to me. The return value indicates whether a snapshot was present and deleted. The ancillary internal state is of no consequence to the caller.

@tmm1
Copy link
Contributor Author

tmm1 commented Jan 21, 2025

Ping

@jrieken jrieken enabled auto-merge April 1, 2025 10:01
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 1, 2025
@jrieken jrieken merged commit 95939ff into microsoft:main Apr 1, 2025
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants