Fix missing uri to file path conversion when loading json schema #237275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
changed the title
misode
changed the title
aeschli
approved these changes
Jan 7, 2025
Contributor
|
Thanks, good catch! |
lszomoru
approved these changes
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #236319. Looking at the diff of that PR, it (most likely by mistake) removed the code to turn the location URI into a valid file path. That was merged 3 weeks ago and is currently affecting insiders, but not stable.
This causes the following error, even though the schema file exists at the mentioned path.
fs.readFilejust doesn't know how to handle URIs. It expects a valid file path.