Skip to content

Conversation

@aslezar
Copy link
Contributor

@aslezar aslezar commented Dec 13, 2024

Hi, I have fixed the parsing error for the GLIBC version with a patch number. I have also added a test case for this. However, I am unable to test it on the remote connection because I am unsure how to compile the vscode-server and deploy it on the host machine.

Fixes #230370

@aslezar
Copy link
Contributor Author

aslezar commented Dec 13, 2024

@microsoft-github-policy-service agree

Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@deepak1556 deepak1556 added this to the January 2025 milestone Dec 16, 2024
@aslezar aslezar requested a review from deepak1556 December 16, 2024 15:24
Copy link
Member

@connor4312 connor4312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@connor4312 connor4312 enabled auto-merge December 16, 2024 15:51
@connor4312 connor4312 merged commit 7fe3227 into microsoft:main Dec 16, 2024
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code is misparsing the glibc version on Fedora Rawhide

3 participants