-
Notifications
You must be signed in to change notification settings - Fork 37.1k
Horizontal dragging auto-scroll #235174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Horizontal dragging auto-scroll #235174
Conversation
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and apologies for the slow turn-around time!
|
Hi @ttttotem thanks for this PR. By git bisecting I have found that this PR causes the issue : #263098. Specifically it's the changes in the file
The linked issue is rather important so it should maybe made into a candidate with a quick fix. |
|
To add more context about the issue above, the PR incorrectly computes that the cursor is outside of the editor, when it is inside of the editor in the following check: |
Issue: #172652
Problem: horizontal dragging does not autoscroll
Solution:
Extension of vertical autoscroll introduced in #161378
Example:
https://github.com/user-attachments/assets/cee1f841-9a00-42bd-844d-9c4d4cecf1f6