Skip to content

Conversation

@ttttotem
Copy link
Contributor

@ttttotem ttttotem commented Dec 3, 2024

Issue: #172652
Problem: horizontal dragging does not autoscroll
Solution:
Extension of vertical autoscroll introduced in #161378
Example:
https://github.com/user-attachments/assets/cee1f841-9a00-42bd-844d-9c4d4cecf1f6

@ttttotem
Copy link
Contributor Author

ttttotem commented Dec 3, 2024

@microsoft-github-policy-service agree

@ttttotem
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and apologies for the slow turn-around time!

@alexdima alexdima enabled auto-merge (squash) July 14, 2025 19:15
@vs-code-engineering vs-code-engineering bot added this to the July 2025 milestone Jul 14, 2025
@alexdima alexdima merged commit 7629bf7 into microsoft:main Jul 14, 2025
17 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 29, 2025
@aiday-mar
Copy link
Contributor

Hi @ttttotem thanks for this PR. By git bisecting I have found that this PR causes the issue : #263098. Specifically it's the changes in the file mouseHandler.ts inside of the method _getPositionOutsideEditor() that cause this issue. I think we need to either:

  • quickly find a solution to the above issue
  • revert this PR

The linked issue is rather important so it should maybe made into a candidate with a quick fix.

@aiday-mar
Copy link
Contributor

To add more context about the issue above, the PR incorrectly computes that the cursor is outside of the editor, when it is inside of the editor in the following check:

		if (e.relativePos.x <= xLeftBoundary) {
			const outsideDistance = xLeftBoundary - e.relativePos.x;
			const position = new Position(possibleLineNumber, 1);			return MouseTarget.createOutsideEditor(mouseColumn, position, 'left', outsideDistance);
		}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants