-
Notifications
You must be signed in to change notification settings - Fork 37.5k
Fix focused stack frame colors in disassembly view #129721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@xisui-MSFT this looks good to me, however i had a hard time getting into a situation to easily try this out with mock-debug. Thanks 👏 |
|
@xisui-MSFT In Mock Debug all |
|
@xisui-MSFT due to other PRs that I merge there are conflicts in this PR now. Can you please resolve the conflicts? Thank you |
|
@isidorn Resolved conflicts. Thanks! |
|
@xisui-MSFT thanks a lot. Merging in 👏 |
This PR fixes #129574
Current stack frame icon is shown when the current stack is in focus, and this line contains the address of the top stack frame.
Current stack frame line background is set when the line contains the address of the top stack frame, no matter if the current stack is in focus.
Focused stack frame icon is shown and focused stack frame line background is set when this line contains the address of the focused stack frame, and it's not the top stack frame.