Skip to content

Conversation

@xisui-MSFT
Copy link
Contributor

This PR fixes #129574

Current stack frame icon is shown when the current stack is in focus, and this line contains the address of the top stack frame.
Current stack frame line background is set when the line contains the address of the top stack frame, no matter if the current stack is in focus.
Focused stack frame icon is shown and focused stack frame line background is set when this line contains the address of the focused stack frame, and it's not the top stack frame.

@xisui-MSFT xisui-MSFT changed the title Focused stack frame colors Fix focused stack frame colors Jul 28, 2021
@xisui-MSFT xisui-MSFT changed the title Fix focused stack frame colors Fix focused stack frame colors in disassembly view Jul 28, 2021
@xisui-MSFT
Copy link
Contributor Author

@isidorn @weinand Can you please take a look? Thanks!

@isidorn
Copy link
Collaborator

isidorn commented Jul 29, 2021

@xisui-MSFT this looks good to me, however i had a hard time getting into a situation to easily try this out with mock-debug.
Did you try it out with C++, does it works as expected.
I looked at the code and it looks good -> approved.
However since I could not try it out end to end I would prefer to merge this start of next week -> August. Please let me know if you would really like to ship this as part of the July release.

Thanks 👏

@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 29, 2021
@isidorn isidorn added this to the August 2021 milestone Jul 29, 2021
@xisui-MSFT
Copy link
Contributor Author

@isidorn I'm fine either shipping this in July or August. And yes I tested this using c++ extension.

@weinand Can you please add a few more levels of stack frames that has instructionPointerReference in disassembly view in the mock debugger? I can probably help as well if you prefer.

@weinand
Copy link
Contributor

weinand commented Jul 29, 2021

@xisui-MSFT In Mock Debug all stackframes have a instructionPointerReference if the corresponding source line contains the word disassembly. Just make sure to use the latest Mock-Debug.

https://github.com/microsoft/vscode-mock-debug/blob/2bbb1d16e6ffafcb80d1d1584174fd9f2f635105/src/mockRuntime.ts#L249-L265

@isidorn
Copy link
Collaborator

isidorn commented Aug 2, 2021

@xisui-MSFT due to other PRs that I merge there are conflicts in this PR now. Can you please resolve the conflicts? Thank you

@xisui-MSFT
Copy link
Contributor Author

@isidorn Resolved conflicts. Thanks!

@isidorn isidorn merged commit a8085da into microsoft:main Aug 3, 2021
@isidorn
Copy link
Collaborator

isidorn commented Aug 3, 2021

@xisui-MSFT thanks a lot. Merging in 👏

@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unfocused stack frame not rendered in disassembly view

3 participants