Skip to content

add command translation for turkish - #8292

Merged
Karthik Nadig (karthiknadig) merged 5 commits into
microsoft:masterfrom
alioguzhan:turkish-cmd-translation
Oct 31, 2019
Merged

Karthik Nadig (karthiknadig) merged 5 commits into
microsoft:masterfrom
alioguzhan:turkish-cmd-translation

Conversation

@alioguzhan

@alioguzhan Ali Oguzhan Yildiz (alioguzhan) commented Oct 30, 2019 •

Copy link
Copy Markdown

For #8320

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Oct 30, 2019 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@codecov-io

Codecov (codecov-io) commented Oct 30, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #8292 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
- Coverage   58.66%   58.65%   -0.01%     
==========================================
  Files         504      504              
  Lines       22719    22728       +9     
  Branches     3731     3732       +1     
==========================================
+ Hits        13327    13332       +5     
- Misses       8500     8504       +4     
  Partials      892      892
Impacted Files Coverage Δ
src/client/common/utils/platform.ts 76.47% <0%> (-11.77%) ⬇️
...rc/client/datascience/errorHandler/errorHandler.ts 67.5% <0%> (-0.15%) ⬇️
src/client/datascience/constants.ts 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f26b2e...daf2c64. Read the comment docs.

@karthiknadig

Copy link
Copy Markdown
Member

Thank you for the translation.

Comment thread README.md Outdated
@karthiknadig

Copy link
Copy Markdown
Member

Ali Oguzhan Yildiz (@alioguzhan) Another minor thing, Use this #8320 as the work item, and change the file name for 8292.md to 8320.md

@karthiknadig

Copy link
Copy Markdown
Member

Everything else looks good. I can merge after that.

@alioguzhan

Copy link
Copy Markdown
Author

Done.

@karthiknadig
Karthik Nadig (karthiknadig) merged commit 796f843 into microsoft:master Oct 31, 2019
@alioguzhan

Copy link
Copy Markdown
Author

Fixes #8320

@lock lock Bot locked as resolved and limited conversation to collaborators Nov 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants