Repository navigation
add command translation for turkish - #8292
Merged
Karthik Nadig (karthiknadig) merged 5 commits intoOct 31, 2019
Merged
Karthik Nadig (karthiknadig) merged 5 commits into
Karthik Nadig (karthiknadig) merged 5 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8292 +/- ##
==========================================
- Coverage 58.66% 58.65% -0.01%
==========================================
Files 504 504
Lines 22719 22728 +9
Branches 3731 3732 +1
==========================================
+ Hits 13327 13332 +5
- Misses 8500 8504 +4
Partials 892 892
Continue to review full report at Codecov.
|
Member
|
Thank you for the translation. |
Karthik Nadig (karthiknadig)
approved these changes
Oct 31, 2019
Member
|
Ali Oguzhan Yildiz (@alioguzhan) Another minor thing, Use this #8320 as the work item, and change the file name for |
Member
|
Everything else looks good. I can merge after that. |
refers to #8320
Author
|
Done. |
Author
|
Fixes #8320 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #8320
Appropriate comments and documentation strings in the codeHas sufficient logging.Unit tests & system/integration tests are added/updatedTest plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)The wiki is updated with any design decisions/details.