Skip to content

Move Jedi to use LSP instead of internal registration #1401

Closed

Description

@rchiodo

This is the second step in making a working intellisense engine for notebooks. Could be based on this:
https://github.com/pappasam/jedi-language-server

Activity

  1. IanMatthewHuff commented on Oct 8, 2020

    @IanMatthewHuff
    Member

    Rich Chiodo (@rchiodo) What can I do to validate this?

  2. rchiodo commented on Oct 8, 2020

    @rchiodo
    ContributorAuthor

    Set your language server to Jedi and then set this experiment to on:

        "python.experiments.optInto": [
            "jediLSP",
        ],

    Reload VS code and then attempt intellisense in a normal python file.

  3. IanMatthewHuff commented on Oct 8, 2020

    @IanMatthewHuff
    Member

    Doesn't seem to be working for me. I get this message and no intellisense:

    image.png

  4. rchiodo commented on Oct 8, 2020

    @rchiodo
    ContributorAuthor

    Are you doing this with the vsix bits or with your debug bits? You need to install the server manually if you're using debug bits

  5. IanMatthewHuff commented on Oct 8, 2020

    @IanMatthewHuff
    Member

    I was using debug bits. I'll just swap over to a VSIX seems easier than installing a server manually.

  6. rchiodo commented on Oct 8, 2020

    @rchiodo
    ContributorAuthor

    You run this to install the server (as well as other requirements)

    python -m pip --disable-pip-version-check install -t ./pythonFiles/lib/python --no-cache-dir --implementation py --no-deps --upgrade --no-user -r ./requirements.txt
    
  7. IanMatthewHuff commented on Oct 8, 2020

    @IanMatthewHuff
    Member

    Not if I use the VSIX though, right? With the most recent insiders VSIX I get the same result.

  8. rchiodo commented on Oct 8, 2020

    @rchiodo
    ContributorAuthor

    Yeah it should work with the VSIX. Maybe something has since broke. There's no tests making sure this continues to work

  9. rchiodo commented on Nov 16, 2020

    @rchiodo
    ContributorAuthor

    This would be on the python team to 'fix' if it doesn't work. Or at least the work would happen in the python extension.

  10. locked as resolved and limited conversation to collaborators on May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions