Skip to content

Conversation

@mikeseese
Copy link
Contributor

This PR adds a githubIssues.alwaysPromptForNewIssueRepo config variable that defaults to false. When set to true, if the user creates a new issue via the + button in the side panel, the extensions will always prompt the user for a repo to create the issue for instead of using the current open file. Behavior should not change for creating issues from selection/etc that are supposed to be directly contextual.

This PR also adds a comment in the NewIssue.md file telling the user which repo the issue will be created in if it's available:

image

This PR fixes #2099.

…hint to new issues

Signed-off-by: Mike Seese <seesemichaelj@gmail.com>
@mikeseese
Copy link
Contributor Author

@microsoft-github-policy-service agree

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have some comments.

… URI scheme

Signed-off-by: Mike Seese <seesemichaelj@gmail.com>
@mikeseese mikeseese force-pushed the feat/multi-repo-issue-creation branch from c9c174f to 6f68dfc Compare July 29, 2024 19:27
@mikeseese mikeseese requested a review from alexr00 July 29, 2024 19:27
@mikeseese
Copy link
Contributor Author

mikeseese commented Jul 29, 2024

@alexr00 It got a little more complex, but now origin will contain information to reproduce the correct folder manager and remote by adding a new repo URI scheme.

@rzhao271
Copy link
Contributor

Merge conflict
Moving the milestone

@rzhao271 rzhao271 modified the milestones: October 2024, November 2024 Oct 25, 2024
@mikeseese
Copy link
Contributor Author

@rzhao271 @alexr00 Merge conflicts have been resolved. This PR is still waiting for a rereview. Thanks!

@alexr00 alexr00 modified the milestones: November 2024, January 2025 Dec 3, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 3, 2024

Thanks for your patience on this! I'll look at it next week when we start our annual clean up iteration.

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikeseese, I had some significant changes I wanted with regard to the URI related opterations and schemes. Rather than make you go through more back and forth to make changes that are really my own debt, I've pushed the changes to your branch. I plan to merge the PR after we release this week. Thank you for the PR!

@mikeseese
Copy link
Contributor Author

Sounds good, thanks!

@alexr00 alexr00 enabled auto-merge (squash) December 9, 2024 17:13
@alexr00 alexr00 merged commit 79a7fcb into microsoft:main Dec 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hint which repo an issue will be opened in

5 participants