Skip to content

Conversation

@joshuaobrien
Copy link
Contributor

Fixes #2540

@ghost
Copy link

ghost commented Jul 19, 2021

CLA assistant check
All CLA requirements met.

}
}

return 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't too sure how to handle the case where this.compareBranch == null. Advice appreciated!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 seems reasonable here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the upstream is undefined we can use the git API to get the number of changes. I have added that.

@alexr00 alexr00 added this to the August 2021 milestone Jul 20, 2021
@alexr00 alexr00 self-assigned this Aug 11, 2021
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

}
}

return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 seems reasonable here.

}
}

return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the upstream is undefined we can use the git API to get the number of changes. I have added that.

@alexr00 alexr00 merged commit 7aabb24 into microsoft:main Aug 11, 2021
@glasser
Copy link

glasser commented Aug 20, 2021

For what it's worth, this doesn't seem to be working for me in v0.29.3. apollographql/apollo-server#5639 is an example of a single-commit PR I just make where I had to put the commit message in the description manually.

@alexr00
Copy link
Member

alexr00 commented Aug 23, 2021

We have not yet made our August Milestone release yet (more info on the timing of our releases: https://github.com/microsoft/vscode-pull-request-github/wiki#4-when-will-the-next-release-occur)

@glasser
Copy link

glasser commented Aug 23, 2021

Ah, OK — I thought that v0.29.3 was after this fix merged and that's what my VSCode is running though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR description should auto fill when the PR is a single commit

3 participants