Skip to content

Remove extra parseTree #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexr00 merged 1 commit into from
Jul 29, 2021
Merged

Remove extra parseTree #406

alexr00 merged 1 commit into from
Jul 29, 2021

Conversation

@james1293
Copy link
Contributor

@james1293 james1293 commented Apr 24, 2021

Hello,
I think this call to parseTree is unnecessary, because line 23 runs onActiveEditorChanged(), which runs refresh(), which runs parseTree.

Let me know your thoughts, thanks!

@sandy081 sandy081 assigned alexr00 and unassigned sandy081 Jun 11, 2021
@alexr00 alexr00 added this to the June 2021 milestone Jun 11, 2021
@Tyriar Tyriar modified the milestones: June 2021, July 2021 Jul 14, 2021
@alexr00
Copy link
Member

alexr00 commented Jul 29, 2021

Doesn't seem like parseTree is needed.

@alexr00 alexr00 merged commit 62e7e59 into microsoft:main Jul 29, 2021
@james1293 james1293 deleted the patch-1 branch November 12, 2021 22:06
tamuratak pushed a commit to tamuratak/vscode-extension-samples that referenced this pull request Apr 29, 2022
@james1293 @tamuratak
Remove extra parseTree (microsoft#406)
8e614fc
@thaileen0411 thaileen0411 mentioned this pull request Mar 24, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels

None yet

Projects

None yet

Milestone

July 2021

Development

Successfully merging this pull request may close these issues.

4 participants

@james1293 @alexr00 @Tyriar @sandy081