Adding VSC hidden family #1996
Merged
Adding VSC hidden family #1996
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the VSC model detection mechanism by adding new hash values to VSC_MODEL_HASHES_A and VSC_MODEL_HASHES_B, and updates the isVSCModelA and isVSCModelB functions to check both model ID and family hashes. The VSC model detection is then integrated into capability checks for apply_patch functionality.
Key changes:
- Added hash values to VSC_MODEL_HASHES_A and VSC_MODEL_HASHES_B arrays
- Modified
isVSCModelAandisVSCModelBto check both model ID and family hashes - Integrated VSC model checks into
modelSupportsApplyPatch,modelCanUseApplyPatchExclusively, andmodelSupportsSimplifiedApplyPatchInstructions
AbdelrahmanAbouelenin
force-pushed
the
ababouelenin/vsc_hidden_family
branch
from
7217055 to
1a8c4f1
Compare
karthiknadig
approved these changes
Nov 14, 2025
bpasero
approved these changes
Nov 14, 2025
karthiknadig
pushed a commit
that referenced
this pull request
Nov 17, 2025
Co-authored-by: AbdelrahmanAbouelenin <abdelrahman.abouelenin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add VSC Family Name to Hash List
added new VSC family names to VSC_MODEL_HASHES_A and VSC_MODEL_HASHES_B.