Add ability to build extension VSIX and swap for built-in extension #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the ability to build and install the tsgo VS Code extension while overriding the built-in TypeScript extension when needed, and it adds a warning-colored status bar item to signal the active tsgo mode.
- Adds a status bar item and associated quick pick menu for extension commands.
- Implements logic to skip activation when the built-in TypeScript extension is active and configuration dictates.
- Updates the Herebyfile to include an insiders option for extension installation.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| _extension/src/extension.ts | Introduces status bar integration, command registration, and modified activation/deactivation logic. |
| README.md | Updates instructions to reflect the new extension build and installation steps. |
| Herebyfile.mjs | Adds an insiders flag and implements a new task to build and install the extension. |
Files not reviewed (1)
- _extension/package.json: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Member
|
Ah, seems like you have the npm bug that Kat fixed; probably want to restore your lockfile to main, delete all node_modules, and then install again. |
jakebailey
reviewed
Apr 17, 2025
jakebailey
reviewed
Apr 17, 2025
Member
There was a problem hiding this comment.
What in the heck is vsce doing with 5000 lines of deps added???
Member
There was a problem hiding this comment.
gabritto
approved these changes
Apr 29, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up a
herebycommand to build and persistently install the tsgo VS Code extension. It does nothing if the default typescript-language-features extension is active. microsoft/vscode#246858 allows for disabling that one via configuration/command, allowing the tsgo LSP to take over. Also adds a warning-colored status bar item to make it obvious when you’re running tsgo instead of stable TypeScript in the editor.Screen.Recording.2025-04-17.at.12.27.57.PM.mov