fix(60908): Unexpected "'Type' is declared but its value is never read." error with jsdoc @import syntax by a-tarasyuk · Pull Request #60921 · microsoft/TypeScript

a-tarasyuk · 2025-01-06T13:37:21Z

Fixes #60908
Fixes #58368

…ainer

regseb · 2025-01-11T17:45:42Z

Maybe this pull request also fixes the issue #58368 (and its duplicate #58969).

jakebailey · 2025-01-13T19:13:45Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2025-01-13T19:13:49Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`pack this`	✅ Started	✅ Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-01-13T19:15:54Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/164532/artifacts?artifactName=tgz&fileId=878483ACBB3ADF254CED52B3B2040E424AF942FC5EA4126C9A5FE68FE33F4ADC02&fileName=/typescript-5.8.0-insiders.20250113.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@5.8.0-pr-60921-3".;

typescript-bot · 2025-01-13T19:34:11Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-01-13T19:35:55Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60921/merge:

Everything looks good!

typescript-bot · 2025-01-13T20:02:45Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{195,638k (± 0.92%)}	_{195,640k (± 0.95%)}	_~	_193,245k	_196,877k	_{p=0.521 n=6}
_{Parse Time}	_{1.61s (± 1.24%)}	_{1.61s (± 2.07%)}	_~	_1.54s	_1.63s	_{p=1.000 n=6}
_{Bind Time}	_{0.87s (± 0.93%)}	_{0.88s (± 1.12%)}	_~	_0.87s	_0.89s	_{p=0.498 n=6}
_{Check Time}	_{11.79s (± 0.56%)}	_{11.87s (± 0.95%)}	_~	_11.75s	_12.01s	_{p=0.423 n=6}
_{Emit Time}	_{3.34s (± 3.05%)}	_{3.31s (± 1.17%)}	_~	_3.27s	_3.37s	_{p=0.872 n=6}
_{Total Time}	_{17.62s (± 0.62%)}	_{17.66s (± 0.75%)}	_~	_17.51s	_17.82s	_{p=0.748 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,969	_947,969	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,955	_410,955	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,839k (± 0.01%)}	_{1,225,843k (± 0.00%)}	_~	_1,225,769k	_1,225,886k	_{p=0.936 n=6}
_{Parse Time}	_{8.04s (± 0.82%)}	_{8.04s (± 1.02%)}	_~	_7.93s	_8.13s	_{p=0.747 n=6}
_{Bind Time}	_{2.28s (± 0.28%)}	_{2.28s (± 1.22%)}	_~	_2.25s	_2.32s	_{p=0.739 n=6}
_{Check Time}	_{38.04s (± 0.21%)}	_{38.23s (± 0.60%)}	_~	_37.98s	_38.56s	_{p=0.078 n=6}
_{Emit Time}	_{18.20s (± 0.97%)}	_{18.17s (± 0.84%)}	_~	_17.96s	_18.38s	_{p=0.810 n=6}
_{Total Time}	_{66.56s (± 0.37%)}	_{66.72s (± 0.39%)}	_~	_66.41s	_67.14s	_{p=0.422 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,445,991	_2,445,991	_~	_~	_~	_{p=1.000 n=6}
_Types	_896,571	_896,571	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,309,956k (± 0.00%)}	_{2,309,948k (± 0.01%)}	_~	_2,309,803k	_2,310,154k	_{p=0.689 n=6}
_{Parse Time}	_{10.79s (± 0.39%)}	_{10.83s (± 0.39%)}	_~	_10.76s	_10.87s	_{p=0.170 n=6}
_{Bind Time}	_{2.51s (± 1.33%)}	_{2.53s (± 0.82%)}	_~	_2.50s	_2.55s	_{p=0.121 n=6}
_{Check Time}	_{87.76s (± 1.05%)}	_{88.81s (± 1.88%)}	_~	_87.07s	_91.07s	_{p=0.298 n=6}
_{Emit Time}	_{0.34s (± 3.06%)}	_{0.35s (± 2.35%)}	_~	_0.34s	_0.36s	_{p=0.121 n=6}
_{Total Time}	_{101.39s (± 0.92%)}	_{102.52s (± 1.59%)}	_~	_100.84s	_104.67s	_{p=0.149 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,377	_1,228,378	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,839	_266,839	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,727,704k (±14.62%)}	_{2,630,600k (±13.74%)}	_~	_2,360,771k	_3,091,916k	_{p=0.378 n=6}
_{Parse Time}	_{6.70s (± 1.30%)}	_{6.59s (± 1.85%)}	_~	_6.47s	_6.79s	_{p=0.149 n=6}
_{Bind Time}	_{2.16s (± 1.93%)}	_{2.17s (± 1.41%)}	_~	_2.11s	_2.19s	_{p=0.806 n=6}
_{Check Time}	_{42.62s (± 0.37%)}	_{42.82s (± 0.86%)}	_~	_42.24s	_43.28s	_{p=0.230 n=6}
_{Emit Time}	_{3.47s (± 1.96%)}	_{3.50s (± 2.13%)}	_~	_3.42s	_3.59s	_{p=0.471 n=6}
_{Total Time}	_{54.94s (± 0.35%)}	_{55.08s (± 0.78%)}	_~	_54.36s	_55.57s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,377	_1,228,378	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_266,839	_266,839	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,157,184k (± 0.03%)}	_{3,156,995k (± 0.02%)}	_~	_3,156,486k	_3,157,887k	_{p=0.936 n=6}
_{Parse Time}	_{8.69s (± 0.52%)}	_{8.67s (± 0.82%)}	_~	_8.56s	_8.74s	_{p=0.748 n=6}
_{Bind Time}	_{2.64s (± 0.52%)}	_{2.63s (± 1.54%)}	_~	_2.58s	_2.67s	_{p=0.514 n=6}
_{Check Time}	_{53.31s (± 0.26%)}	_{53.37s (± 0.37%)}	_~	_53.07s	_53.63s	_{p=0.575 n=6}
_{Emit Time}	_{4.32s (± 1.93%)}	_{4.31s (± 1.60%)}	_~	_4.21s	_4.38s	_{p=0.470 n=6}
_{Total Time}	_{68.96s (± 0.16%)}	_{68.96s (± 0.39%)}	_~	_68.63s	_69.29s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,624	_262,625	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,695	_106,695	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,851k (± 0.01%)}	_{440,784k (± 0.02%)}	_~	_440,628k	_440,897k	_{p=0.471 n=6}
_{Parse Time}	_{3.56s (± 1.19%)}	_{3.52s (± 0.66%)}	_~	_3.49s	_3.54s	_{p=0.107 n=6}
_{Bind Time}	_{1.31s (± 0.57%)}	_{1.31s (± 0.79%)}	_~	_1.30s	_1.33s	_{p=0.931 n=6}
_{Check Time}	_{19.03s (± 0.36%)}	_{18.94s (± 0.31%)}	_~	_18.87s	_19.03s	_{p=0.077 n=6}
_{Emit Time}	_{1.54s (± 0.71%)}	_{1.54s (± 0.53%)}	_~	_1.52s	_1.54s	_{p=0.389 n=6}
_{Total Time}	_{25.44s (± 0.22%)}	_{25.31s (± 0.29%)}	_{-0.13s (- 0.50%)}	_25.21s	_25.39s	_{p=0.013 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,095	_226,095	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,651k (± 0.01%)}	_{371,746k (± 0.04%)}	_~	_371,643k	_371,933k	_{p=0.575 n=6}
_{Parse Time}	_{2.91s (± 1.16%)}	_{2.89s (± 1.11%)}	_~	_2.85s	_2.93s	_{p=0.125 n=6}
_{Bind Time}	_{1.60s (± 1.33%)}	_{1.59s (± 0.51%)}	_~	_1.58s	_1.60s	_{p=0.677 n=6}
_{Check Time}	_{16.52s (± 0.50%)}	_{16.48s (± 0.17%)}	_~	_16.45s	_16.52s	_{p=0.873 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{21.03s (± 0.59%)}	_{20.96s (± 0.20%)}	_~	_20.91s	_21.02s	_{p=0.630 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,238,966	_3,238,966	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,115,494	_1,115,494	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,306,731k (± 0.01%)}	_{3,306,843k (± 0.01%)}	_~	_3,306,321k	_3,307,138k	_{p=0.470 n=6}
_{Parse Time}	_{14.20s (± 0.16%)}	_{14.18s (± 0.49%)}	_~	_14.11s	_14.31s	_{p=0.294 n=6}
_{Bind Time}	_{4.59s (± 2.63%)}	_{4.65s (± 2.93%)}	_~	_4.53s	_4.84s	_{p=0.373 n=6}
_{Check Time}	_{88.19s (± 1.33%)}	_{89.66s (± 2.27%)}	_~	_87.12s	_92.27s	_{p=0.575 n=6}
_{Emit Time}	_{27.92s (± 1.83%)}	_{27.75s (± 1.96%)}	_~	_27.27s	_28.69s	_{p=0.422 n=6}
_{Total Time}	_{134.90s (± 1.22%)}	_{136.24s (± 1.60%)}	_~	_133.45s	_139.68s	_{p=0.298 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_291,595	_291,595	_~	_~	_~	_{p=1.000 n=6}
_Types	_118,971	_118,971	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{445,325k (± 0.02%)}	_{445,429k (± 0.02%)}	_~	_445,308k	_445,560k	_{p=0.128 n=6}
_{Parse Time}	_{4.10s (± 0.93%)}	_{4.10s (± 1.33%)}	_~	_4.03s	_4.20s	_{p=1.000 n=6}
_{Bind Time}	_{1.76s (± 0.46%)}	_{1.78s (± 1.48%)}	_~	_1.74s	_1.82s	_{p=0.157 n=6}
_{Check Time}	_{18.77s (± 0.28%)}	_{18.79s (± 0.48%)}	_~	_18.70s	_18.91s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.64s (± 0.30%)}	_{24.67s (± 0.54%)}	_~	_24.56s	_24.90s	_{p=1.000 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,050	_555,050	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,115	_186,115	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{493,942k (± 0.01%)}	_{493,927k (± 0.01%)}	_~	_493,888k	_493,972k	_{p=0.748 n=6}
_{Parse Time}	_{2.76s (± 0.23%)}	_{2.77s (± 0.40%)}	_~	_2.76s	_2.79s	_{p=0.081 n=6}
_{Bind Time}	_{0.96s (± 0.78%)}	_{0.96s (± 0.57%)}	_~	_0.96s	_0.97s	_{p=0.137 n=6}
_{Check Time}	_{16.26s (± 0.25%)}	_{16.25s (± 0.37%)}	_~	_16.19s	_16.34s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.98s (± 0.21%)}	_{19.99s (± 0.29%)}	_~	_19.92s	_20.06s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-01-13T20:49:25Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60921/merge:

Everything looks good!

jakebailey · 2025-01-17T18:13:12Z

Looking at the playground, I believe this does fix #58368, yes.

Before: Playground Link
After: Playground Link

src/compiler/binder.ts

…ix/60908

sandersn · 2025-03-14T22:44:26Z

@typescript-bot test it

typescript-bot · 2025-03-14T22:44:31Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

src/compiler/binder.ts

typescript-bot · 2025-03-14T23:06:52Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/60921/merge:

Everything looks good!

typescript-bot · 2025-03-14T23:08:22Z

Hey @sandersn, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-03-14T23:30:11Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,919k (± 0.01%)}	_{194,151k (± 0.99%)}	_~	_192,898k	_196,708k	_{p=0.470 n=6}
_{Parse Time}	_1.31s	_{1.31s (± 0.39%)}	_~	_1.31s	_1.32s	_{p=0.174 n=6}
_{Bind Time}	_{0.73s (± 0.56%)}	_0.73s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.76s (± 0.43%)}	_{9.76s (± 0.26%)}	_~	_9.74s	_9.81s	_{p=1.000 n=6}
_{Emit Time}	_{2.73s (± 0.65%)}	_{2.74s (± 0.44%)}	_~	_2.72s	_2.75s	_{p=0.560 n=6}
_{Total Time}	_{14.52s (± 0.23%)}	_{14.54s (± 0.21%)}	_~	_14.50s	_14.59s	_{p=0.687 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₆	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,670	_948,670	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,947	_410,947	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,326k (± 0.00%)}	_{1,224,276k (± 0.00%)}	_~	_1,224,231k	_1,224,319k	_{p=0.109 n=6}
_{Parse Time}	_{6.62s (± 0.88%)}	_{6.67s (± 0.30%)}	_~	_6.65s	_6.70s	_{p=0.086 n=6}
_{Bind Time}	_{1.89s (± 0.78%)}	_{1.88s (± 0.67%)}	_~	_1.87s	_1.90s	_{p=0.321 n=6}
_{Check Time}	_{31.98s (± 0.29%)}	_{31.93s (± 0.36%)}	_~	_31.82s	_32.12s	_{p=0.470 n=6}
_{Emit Time}	_{15.26s (± 0.36%)}	_{15.29s (± 0.69%)}	_~	_15.11s	_15.41s	_{p=0.630 n=6}
_{Total Time}	_{55.75s (± 0.27%)}	_{55.77s (± 0.20%)}	_~	_55.62s	_55.96s	_{p=0.810 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,363,439	_2,363,439	_~	_~	_~	_{p=1.000 n=6}
_Types	_846,685	_846,685	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,133,320k (± 0.01%)}	_{2,133,396k (± 0.01%)}	_~	_2,133,239k	_2,133,537k	_{p=0.378 n=6}
_{Parse Time}	_{7.21s (± 0.15%)}	_{7.21s (± 0.37%)}	_~	_7.17s	_7.24s	_{p=0.870 n=6}
_{Bind Time}	_{2.50s (± 0.53%)}	_{2.49s (± 0.62%)}	_~	_2.47s	_2.51s	_{p=0.222 n=6}
_{Check Time}	_{73.79s (± 0.62%)}	_{73.68s (± 0.37%)}	_~	_73.37s	_74.08s	_{p=0.689 n=6}
_{Emit Time}	_0.16s	_{0.15s (± 3.53%)}	_~	_0.15s	_0.16s	_{p=0.071 n=6}
_{Total Time}	_{83.66s (± 0.54%)}	_{83.55s (± 0.32%)}	_~	_83.22s	_83.91s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,713	_1,226,713	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,991	_266,991	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,967,234k (±10.03%)}	_{3,088,516k (± 0.02%)}	_~	_3,087,735k	_3,089,215k	_{p=1.000 n=6}
_{Parse Time}	_{6.73s (± 1.04%)}	_{6.73s (± 0.95%)}	_~	_6.64s	_6.81s	_{p=0.873 n=6}
_{Bind Time}	_{2.17s (± 2.09%)}	_{2.15s (± 1.89%)}	_~	_2.10s	_2.22s	_{p=0.521 n=6}
_{Check Time}	_{42.92s (± 0.28%)}	_{42.96s (± 0.13%)}	_~	_42.90s	_43.03s	_{p=0.173 n=6}
_{Emit Time}	_{3.52s (± 2.80%)}	_{3.49s (± 2.60%)}	_~	_3.32s	_3.56s	_{p=0.521 n=6}
_{Total Time}	_{55.34s (± 0.19%)}	_{55.32s (± 0.19%)}	_~	_55.21s	_55.50s	_{p=0.748 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,713	_1,226,713	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,991	_266,991	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,791,081k (±14.23%)}	_{2,911,802k (±12.86%)}	_~	_2,427,093k	_3,154,249k	_{p=0.936 n=6}
_{Parse Time}	_{6.88s (± 1.53%)}	_{6.91s (± 1.76%)}	_~	_6.73s	_7.03s	_{p=0.575 n=6}
_{Bind Time}	_{2.14s (± 1.94%)}	_{2.17s (± 2.45%)}	_~	_2.13s	_2.27s	_{p=0.327 n=6}
_{Check Time}	_{42.66s (± 0.33%)}	_{42.65s (± 0.40%)}	_~	_42.48s	_42.88s	_{p=1.000 n=6}
_{Emit Time}	_{3.50s (± 2.19%)}	_{3.52s (± 1.68%)}	_~	_3.44s	_3.61s	_{p=0.936 n=6}
_{Total Time}	_{55.17s (± 0.50%)}	_{55.25s (± 0.50%)}	_~	_54.83s	_55.57s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,674	_262,674	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,849	_106,849	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,338k (± 0.01%)}	_{440,336k (± 0.02%)}	_~	_440,193k	_440,438k	_{p=1.000 n=6}
_{Parse Time}	_{2.89s (± 0.80%)}	_{2.89s (± 0.47%)}	_~	_2.88s	_2.91s	_{p=0.803 n=6}
_{Bind Time}	_{1.11s (± 0.37%)}	_1.11s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{15.81s (± 0.20%)}	_{15.76s (± 0.48%)}	_~	_15.65s	_15.86s	_{p=0.335 n=6}
_{Emit Time}	_{1.30s (± 1.27%)}	_{1.30s (± 1.73%)}	_~	_1.27s	_1.32s	_{p=1.000 n=6}
_{Total Time}	_{21.10s (± 0.22%)}	_{21.06s (± 0.38%)}	_~	_20.95s	_21.18s	_{p=0.377 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,981	_225,981	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,356	_94,356	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,222k (± 0.01%)}	_{371,262k (± 0.03%)}	_~	_371,176k	_371,471k	_{p=0.810 n=6}
_{Parse Time}	_{2.90s (± 1.67%)}	_{2.88s (± 0.83%)}	_~	_2.86s	_2.92s	_{p=0.333 n=6}
_{Bind Time}	_{1.58s (± 0.86%)}	_{1.58s (± 1.06%)}	_~	_1.56s	_1.60s	_{p=0.676 n=6}
_{Check Time}	_{16.49s (± 0.27%)}	_{16.51s (± 0.44%)}	_~	_16.43s	_16.64s	_{p=0.745 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.96s (± 0.30%)}	_{20.97s (± 0.49%)}	_~	_20.87s	_21.16s	_{p=0.809 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₈	₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,303,990	_3,303,990	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,118,747	_1,118,747	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,364,753k (± 0.01%)}	_{3,364,728k (± 0.01%)}	_~	_3,364,546k	_3,365,076k	_{p=0.810 n=6}
_{Parse Time}	_{14.57s (± 0.66%)}	_{14.63s (± 0.66%)}	_~	_14.50s	_14.74s	_{p=0.261 n=6}
_{Bind Time}	_{4.66s (± 0.84%)}	_{4.72s (± 2.71%)}	_~	_4.62s	_4.88s	_{p=0.746 n=6}
_{Check Time}	_{93.22s (± 2.98%)}	_{91.03s (± 2.45%)}	_~	_88.85s	_94.08s	_{p=0.173 n=6}
_{Emit Time}	_{27.11s (±10.11%)}	_{28.42s (± 7.30%)}	_~	_24.34s	_30.35s	_{p=1.000 n=6}
_{Total Time}	_{139.55s (± 1.39%)}	_{138.80s (± 1.34%)}	_~	_137.02s	_141.84s	_{p=0.230 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_308,237	_308,237	_~	_~	_~	_{p=1.000 n=6}
_Types	_134,948	_134,948	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{463,367k (± 0.03%)}	_{463,279k (± 0.02%)}	_~	_463,165k	_463,408k	_{p=0.173 n=6}
_{Parse Time}	_{4.11s (± 0.37%)}	_{4.11s (± 0.85%)}	_~	_4.06s	_4.15s	_{p=0.805 n=6}
_{Bind Time}	_{1.81s (± 1.19%)}	_{1.78s (± 1.48%)}	_~	_1.75s	_1.82s	_{p=0.147 n=6}
_{Check Time}	_{20.46s (± 0.17%)}	_{20.46s (± 0.43%)}	_~	_20.31s	_20.55s	_{p=0.872 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=1.000 n=6}
_{Total Time}	_{26.39s (± 0.10%)}	_{26.34s (± 0.31%)}	_~	_26.26s	_26.46s	_{p=0.420 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_558,554	_558,554	_~	_~	_~	_{p=1.000 n=6}
_Types	_188,194	_188,194	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{492,289k (± 0.04%)}	_{492,253k (± 0.02%)}	_~	_492,035k	_492,374k	_{p=0.423 n=6}
_{Parse Time}	_{3.35s (± 0.44%)}	_{3.35s (± 0.15%)}	_~	_3.35s	_3.36s	_{p=1.000 n=6}
_{Bind Time}	_{1.20s (± 0.63%)}	_{1.20s (± 1.33%)}	_~	_1.17s	_1.21s	_{p=0.485 n=6}
_{Check Time}	_{19.77s (± 0.34%)}	_{19.80s (± 0.34%)}	_~	_19.72s	_19.90s	_{p=0.688 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.33s (± 0.26%)}	_{24.36s (± 0.33%)}	_~	_24.26s	_24.47s	_{p=0.518 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-03-15T00:17:43Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60921/merge:

Everything looks good!

fix(60908): avoid binding jsdocimport children to the jsdoc host cont…

7d1ed12

…ainer

typescript-bot added For Uncommitted Bug PR for untriaged, rejected, closed or missing bug For Backlog Bug PRs that fix a backlog bug and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 6, 2025

a-tarasyuk marked this pull request as ready for review January 10, 2025 20:42

add additional tests

49cdbda

typescript-bot assigned sandersn Jan 17, 2025

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Jan 17, 2025

jakebailey reviewed Jan 17, 2025

View reviewed changes

src/compiler/binder.ts Outdated Show resolved Hide resolved

a-tarasyuk added 4 commits January 20, 2025 01:48

prevent early binding of importClause in jsdoc imports

7c18a9c

Merge branch 'main' of https://github.com/microsoft/TypeScript into f…

9f439bb

…ix/60908

add tests

58f9d2f

experiment: treat import tag as a container

9649ed0

jakebailey reviewed Mar 14, 2025

View reviewed changes

src/compiler/binder.ts Show resolved Hide resolved

a-tarasyuk requested a review from sandersn March 17, 2025 12:12

a-tarasyuk requested a review from jakebailey March 17, 2025 12:12

add clarifying comment

d7a3e0c

sandersn approved these changes Mar 17, 2025

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Mar 17, 2025

jakebailey approved these changes Mar 17, 2025

View reviewed changes

jakebailey merged commit ee3dd72 into microsoft:main Mar 17, 2025
32 checks passed

github-project-automation bot moved this from Needs merge to Done in PR Backlog Mar 17, 2025

sandersn removed this from PR Backlog Apr 22, 2025

DavidBruant mentioned this pull request Apr 22, 2025

Unexpected "'Type' is declared but its value is never read." error with jsdoc @import syntax #60908

Open

microsoft locked as resolved and limited conversation to collaborators Oct 15, 2025

Conversation

a-tarasyuk commented Jan 6, 2025 • edited by jakebailey Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

regseb commented Jan 11, 2025

Uh oh!

jakebailey commented Jan 13, 2025

Uh oh!

typescript-bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jan 13, 2025

Uh oh!

typescript-bot commented Jan 13, 2025

Uh oh!

typescript-bot commented Jan 13, 2025

tsc

Uh oh!

typescript-bot commented Jan 13, 2025

Uh oh!

jakebailey commented Jan 17, 2025

Uh oh!

Uh oh!

sandersn commented Mar 14, 2025

Uh oh!

typescript-bot commented Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

typescript-bot commented Mar 14, 2025

Uh oh!

typescript-bot commented Mar 14, 2025

Uh oh!

typescript-bot commented Mar 14, 2025

tsc

Uh oh!

typescript-bot commented Mar 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

a-tarasyuk commented Jan 6, 2025 •

edited by jakebailey

Loading

typescript-bot commented Jan 13, 2025 •

edited

Loading

typescript-bot commented Jan 13, 2025 •

edited

Loading

typescript-bot commented Mar 14, 2025 •

edited

Loading