remove JSDOC object->any rewrite for noImplicitAny

[sandersn]

Turns out only the Object -> any rewrite got removed. We may have already done some analysis of this change, but I created this PR to easily run it again.

Fixes #34980

[sandersn]

@typescript-bot user test this

[typescript-bot]

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 16c36d0. You can monitor the build here. It should now contribute to this PR's status checks.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[sandersn]

By the numbers:

• 7 failures in compiler tests
• 19 new failures in axios
• 1 failure in content-disposition
• 4 failures in prettier
• 97 new failures in webpack

I know that webpack and prettier use checkJS; 97 new errors in webpack is concerning.

The new error in content-disposition is good -- catches a bare return when the function claims to return object. (assuming strictNullChecks, which the test suite does)

I'll look at the axios-src, prettier, and webpack failures next.

[sandersn]

axios-src has

• 1 usage where object is clearly used to mean { [s: string]: any }.
• 1 usage where it basically means any.

prettier

• 1 options usage where at least they said "TBD???"

[sandersn]

webpack has

• 1 frequently used property where object means any in a TBD sort of sense.

There might some others but I ran out of time to look at all the errors -- most of them are the same missing properties from the aforementioned object.

Overall, I think it's clear that real uses of object as any, or at least a string index signature, exist. I'm going to put this change behind --noImplicitAny like the Object change.

[sandersn]

I'll fix up any test failures tomorrow.

[sandersn]

@weswigham @andrewbranch ping!

[andrewbranch]

I would personally love if we could do this without noImplicitAny, because when I choose to use JS+JSDoc instead of TS, it’s often because I have a bunch of untyped dependencies and writing definitions/stubs for them doesn’t feel worth it, so I disable noImplicitAny, but I still know what object means. But, webpack is probably more important than me 😛