[Metal] Add support for -Fre for Metal - #8159
Merged
Chris B (llvm-beanz) merged 3 commits intoMar 9, 2026
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This updates the Metal support to enable generating the Metal Shader Converter's reflection JSON file. This is required to fix llvm/offload-test-suite#452
Chris B (llvm-beanz)
force-pushed
the
cbieneman/metal-reflection
branch
from
February 12, 2026 22:33
e189319 to
83b8391
Compare
Ashley Coleman (V-FEXrt)
approved these changes
Feb 13, 2026
Farzon Lotfi (farzonl)
approved these changes
Feb 13, 2026
Nathan Gauër (Keenuts)
requested changes
Feb 19, 2026
Nathan Gauër (Keenuts)
left a comment
Nathan Gauër (Keenuts)
left a comment
Collaborator
There was a problem hiding this comment.
Patching this PR and checking Metal codegen, I have an assert because the reflection output seems to be written before.
Seems like the fix is to do:
--- a/tools/clang/tools/dxcompiler/dxcompilerobj.cpp
+++ b/tools/clang/tools/dxcompiler/dxcompilerobj.cpp
@@ -1085,7 +1085,12 @@ public:
}
}
- if (pReflectionStream && pReflectionStream->GetPtrSize()) {
+#ifdef ENABLE_METAL_CODEGEN
+ const bool GenMetal = opts.GenMetal;
+#else
+ const bool GenMetal = false;
+#endif
+ if (!GenMetal && pReflectionStream && pReflectionStream->GetPtrSize()) {
CComPtr<IDxcBlob> pReflection;
IFT(pReflectionStream->QueryInterface(&pReflection));
IFT(pResult->SetOutputObject(DXC_OUT_REFLECTION, pReflection));
cbieneman/metal-reflection
Nathan Gauër (Keenuts)
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Metal support to enable generating the Metal Shader Converter's reflection JSON file.
Required to fix llvm/offload-test-suite#452.