Skip to content

Fix vk::BufferPointer for non-SPIR-V builds#7305

Closed
dneto0 wants to merge 2 commits intomicrosoft:mainfrom
dneto0:fix-break
Closed

Fix vk::BufferPointer for non-SPIR-V builds#7305
dneto0 wants to merge 2 commits intomicrosoft:mainfrom
dneto0:fix-break

Conversation

@dneto0
Copy link
Copy Markdown
Collaborator

@dneto0 dneto0 commented Apr 3, 2025

PR #7163 added support for vk::BufferPointer

It did not build when building for non-SPIR-V scenarios.

Bug: crbug.com/408215487

PR microsoft#7163 added support for vk::BufferPointer

It did not build when building for non-SPIR-V scenarios.

Bug: crbug.com/408215487
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2025

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff c9170e5fc5d39d472af1d5e5c2cf368a4501bc1a d4cd8227ec11c73a3795be336062b06dc6dfc6d2 -- include/dxc/dxcapi.internal.h tools/clang/lib/Sema/SemaHLSL.cpp
View the diff from clang-format here.
diff --git a/include/dxc/dxcapi.internal.h b/include/dxc/dxcapi.internal.h
index 914a4c3c..3ace3c32 100644
--- a/include/dxc/dxcapi.internal.h
+++ b/include/dxc/dxcapi.internal.h
@@ -136,10 +136,10 @@ enum LEGAL_INTRINSIC_COMPTYPES {
   LICOMPTYPE_VK_BUFFER_POINTER = 52,
 
   LICOMPTYPE_COUNT = 53
-#else   // ENABLE_SPIRV_CODEGEN
+#else  // ENABLE_SPIRV_CODEGEN
 
   LICOMPTYPE_COUNT = 52
-#endif  // ENABLE_SPIRV_CODEGEN
+#endif // ENABLE_SPIRV_CODEGEN
 };
 
 static const BYTE IA_SPECIAL_BASE = 0xf0;
  • Check this box to apply formatting changes to this branch.

@amaiorano
Copy link
Copy Markdown
Collaborator

Actually, the author of the original change put up a similar fix: #7306
We'll go with that one to keep ownership of the the changes with one person.

@dneto0 dneto0 closed this Apr 3, 2025
@github-project-automation github-project-automation bot moved this from New to Done in HLSL Roadmap Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants