Fix vk::BufferPointer for non-SPIR-V builds#7305
Closed
dneto0 wants to merge 2 commits intomicrosoft:mainfrom
Closed
Fix vk::BufferPointer for non-SPIR-V builds#7305dneto0 wants to merge 2 commits intomicrosoft:mainfrom
dneto0 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
PR microsoft#7163 added support for vk::BufferPointer It did not build when building for non-SPIR-V scenarios. Bug: crbug.com/408215487
Contributor
You can test this locally with the following command:git-clang-format --diff c9170e5fc5d39d472af1d5e5c2cf368a4501bc1a d4cd8227ec11c73a3795be336062b06dc6dfc6d2 -- include/dxc/dxcapi.internal.h tools/clang/lib/Sema/SemaHLSL.cppView the diff from clang-format here.diff --git a/include/dxc/dxcapi.internal.h b/include/dxc/dxcapi.internal.h
index 914a4c3c..3ace3c32 100644
--- a/include/dxc/dxcapi.internal.h
+++ b/include/dxc/dxcapi.internal.h
@@ -136,10 +136,10 @@ enum LEGAL_INTRINSIC_COMPTYPES {
LICOMPTYPE_VK_BUFFER_POINTER = 52,
LICOMPTYPE_COUNT = 53
-#else // ENABLE_SPIRV_CODEGEN
+#else // ENABLE_SPIRV_CODEGEN
LICOMPTYPE_COUNT = 52
-#endif // ENABLE_SPIRV_CODEGEN
+#endif // ENABLE_SPIRV_CODEGEN
};
static const BYTE IA_SPECIAL_BASE = 0xf0;
|
amaiorano
approved these changes
Apr 3, 2025
Collaborator
|
Actually, the author of the original change put up a similar fix: #7306 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #7163 added support for vk::BufferPointer
It did not build when building for non-SPIR-V scenarios.
Bug: crbug.com/408215487