Merge needed march release followups into mesh nodes#6786
Merged
pow2clk merged 4 commits intomicrosoft:release-preview-mesh-nodesfrom Jul 16, 2024
Merged
Merge needed march release followups into mesh nodes#6786pow2clk merged 4 commits intomicrosoft:release-preview-mesh-nodesfrom
pow2clk merged 4 commits intomicrosoft:release-preview-mesh-nodesfrom
Conversation
) (microsoft#6457) Use identifier name without check the identifier exists will cause crash. Fixes microsoft#6426 --------- Co-authored-by: Tex Riddell <texr@microsoft.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 7581ff4) (cherry picked from commit 11e1318)
bob80905
approved these changes
Jul 15, 2024
Collaborator
Author
|
The failure looks like a fluke. I can't see any actual failure message in the log. Rerunning |
This PR contains two changes: 1) Moves a pragma to disable a warning, which seems to be required by the new compiler. 2) Adds a preprocessor define to workaround the crashes caused by the runner image mismatching C++ runtime versions. The second change we will want to revert once the runner images are fixed. The issue tracking the runner images is: actions/runner-images#10004 Related microsoft#6668 (cherry picked from commit 0b9acdb)
This removes the hack introduced in microsoft#6683 to workaround issues in the GitHub and ADO runner image: actions/runner-images#10004 Rumor has it the runner images are now fixed... let's see. Fixes microsoft#6674 (cherry picked from commit 98bb80a)
Collaborator
Author
|
This raft of cherry picks that collectively change just one line should be enough to fix the debug build and also keep the history consistent with main. They became necessary due to changes in the way MSVC produces warnings |
pow2clk
changed the title
damyanp
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the following changes into mesh nodes to fix a known bug that required a point release in the march release branch and also some build fixes for new visual studio diagnostics.
9ca52f4 Add duplicate pragma (#6732)
7809c0b Remove Windows C++ redist hack (#6692)
33277a1 Workaround broken GitHub runner images (#6683)
1b9a796 [Sema] Check FunctionDecl has identifier before getName. (#6439) (#6457)