Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: micro/go-micro
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: micro/go-micro
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: copilot/fix-etcd-authentication-performance
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 5 files changed
  • 2 contributors

Commits on Jan 9, 2026

  1. Initial plan

    Copilot committed Jan 9, 2026
    Configuration menu
    Copy the full SHA
    37a38d2 View commit details
    Browse the repository at this point in the history

  2. Add adaptive throttling to prevent cache penetration without stale cache 

    Implement rate limiting mechanism to protect etcd when:
- Cache is empty (no stale data available)
- Registry is failing/overloaded
- Multiple sequential requests arrive

Changes:
- Add MinimumRetryInterval option (default 5s)
- Track last failed attempt time per service
- Throttle requests within retry interval when no cache exists
- Clear throttling on successful lookup
- Add comprehensive tests validating throttling behavior

Co-authored-by: asim <17530+asim@users.noreply.github.com>
    @asim
    Copilot and asim committed Jan 9, 2026
    Configuration menu
    Copy the full SHA
    42a12fe View commit details
    Browse the repository at this point in the history

  3. Fix WaitGroup race condition in events stream tests 

    The WaitGroup.Add() calls were happening after goroutines started,
causing a race where Done() could be called before Add(), resulting
in "negative WaitGroup counter" panics.

Fixes:
- Move wg.Add(1) before goroutine in TestConsumeTopic
- Move wg.Add(2) before first goroutine in TestConsumeGroup

Co-authored-by: asim <17530+asim@users.noreply.github.com>
    @asim
    Copilot and asim committed Jan 9, 2026
    Configuration menu
    Copy the full SHA
    2850d50 View commit details
    Browse the repository at this point in the history

  4. Update registry cache documentation with adaptive throttling feature 

    Document the new adaptive throttling feature that prevents cache
penetration when registry is failing and no stale cache exists.

Includes:
- Feature overview
- Usage examples with configuration options
- Explanation of throttling behavior
- Example scenario demonstrating protection

Co-authored-by: asim <17530+asim@users.noreply.github.com>
    @asim
    Copilot and asim committed Jan 9, 2026
    Configuration menu
    Copy the full SHA
    38a8f5f View commit details
    Browse the repository at this point in the history
Loading