Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: googleapis/google-cloud-python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: michaelenglo/google-cloud-python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 2 contributors

Commits on Jun 28, 2017

  1. strip padding characters from urlsafe

    Michael Englo committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    1196a36 View commit details
    Browse the repository at this point in the history

  2. Update key.py

    Michael Englo authored Jun 28, 2017
    Configuration menu
    Copy the full SHA
    97237f7 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary comment in from_legacy_urlsafe. 

    Since both stripped and non-stripped padding should be acceptable.
    Michael Englo authored Jun 28, 2017
    Configuration menu
    Copy the full SHA
    337aeb9 View commit details
    Browse the repository at this point in the history

  4. move padding to below the _to_bytes

    Michael Englo authored Jun 28, 2017
    Configuration menu
    Copy the full SHA
    d7918f7 View commit details
    Browse the repository at this point in the history

  5. Adding some tests to exercise padding code in (to|from)_legacy_urlsaf… 

    …e().
    @dhermes
    dhermes committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    782edda View commit details
    Browse the repository at this point in the history
Loading