-
Notifications
You must be signed in to change notification settings - Fork 195
[master < T1220-MG] Fix bug on properties in c++ api #732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
antepusic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work! Would it make sense to replace string_view with string elsewhere in the API as well?
…et|Get)Property on vertex|edge
Since there are no problems, I would leave it as is. |
antaljanosbenjamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment about StealType.
antepusic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to go 🚀
This PR fixes few bugs:
std::string_viewwas used as a key to store Properties instd::map, due to the nature of how properties are retrieved frommgp_properties_get_nextin combination withstd::string_view, the new property would overwrite the old one and the user wouldn't get the correct state of properties (some would miss, std::map would be filled with same property)mgp.hppand_mgp.hpp[master < Task] PR