Skip to content

Avoid adding to history epochs which didn't update database #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
as51340 merged 3 commits into from
Aug 5, 2025
Merged

Avoid adding to history epochs which didn't update database #3141

as51340 merged 3 commits into from
Aug 5, 2025

Conversation

@as51340
Copy link
Contributor

@as51340 as51340 commented Jul 27, 2025 •
edited
Loading

When loading WAL we were adding epochs to history without checking whether it actually contained some changes.

@as51340 as51340 added this to the mg-v3.5.0 milestone Jul 27, 2025
@as51340 as51340 self-assigned this Jul 27, 2025
@as51340 as51340 added Docs unnecessary Docs unnecessary Code improvements CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push labels Jul 27, 2025
@as51340
Copy link
Contributor Author

as51340 commented Jul 27, 2025 •
edited
Loading

Tracking

  • [Link to Epic/Issue]

Standard development

CI Testing Labels

  • Select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label
  • Add the bug / feature label
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • In HA, while loading WAL file after instance's restart, it will be checked whether WAL actually contains some changes before saving WAL's epoch to history. Users could benefit from it since it they will see less often brute-force recovery of replica and more of incremental recovery with only the data that replica needs. #3141
    • What has changed? What does it mean for a user? What should a user do with it? [#{{PR_number}}]({{link to the PR}})
  • [ Documentation PR link memgraph/documentation#XXXX ]
    • Is back linked to this development PR

@as51340 as51340 force-pushed the epoch-wal-loading branch from ceeb10e to 3acd12b Compare August 4, 2025 09:24
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@as51340 as51340 marked this pull request as ready for review August 4, 2025 19:31
@as51340 as51340 requested a review from andrejtonev August 4, 2025 19:32
@as51340 as51340 changed the title Avoid adding to history epochs which didn't modify db Avoid adding to history epochs which didn't update database Aug 4, 2025
@as51340 as51340 added this pull request to the merge queue Aug 5, 2025
Merged via the queue into master with commit 9c511bd Aug 5, 2025
35 checks passed
@as51340 as51340 deleted the epoch-wal-loading branch August 5, 2025 12:08
@as51340 as51340 added Docs - changelog only Docs - changelog only and removed Docs unnecessary Docs unnecessary labels Aug 7, 2025
@gitbuda gitbuda mentioned this pull request Aug 17, 2025
Merged
81 tasks
as51340 added a commit that referenced this pull request Oct 24, 2025
@as51340
Avoid adding to history epochs which didn't update database (#3141)
f3dbf81 
When loading WAL we were adding epochs to history without checking
whether it actually contained some changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrejtonev andrejtonev andrejtonev approved these changes

Assignees

@as51340 as51340

Labels

Capability - high-availability CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push Code improvements Docs - changelog only Docs - changelog only

Projects

None yet

Milestone

mg-v3.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@as51340 @andrejtonev